TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

morph/GetContractByID: Fix error handling when contract not found #1211

Open
achuprov wants to merge 1 commits from achuprov/frostfs-node:bugfix/ftostfd-adm_panic_contact_id into master
pull from: achuprov/frostfs-node:bugfix/ftostfd-adm_panic_contact_id
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files Changed 16
achuprov commented 2024-06-27 16:30:37 +00:00
Collaborator

Close: #1210

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close: #1210 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-06-27 16:30:52 +00:00
DCO action / DCO (pull_request) Successful in 3m46s Details
Vulncheck / Vulncheck (pull_request) Successful in 4m20s Details
Build / Build Components (1.21) (pull_request) Successful in 5m30s Details
Build / Build Components (1.22) (pull_request) Successful in 6m48s Details
Tests and linters / gopls check (pull_request) Failing after 6m17s Details
Tests and linters / Lint (pull_request) Successful in 7m19s Details
Tests and linters / Staticcheck (pull_request) Successful in 9m27s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 11m1s Details
Tests and linters / Tests with -race (pull_request) Successful in 11m53s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 12m7s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 12m34s Details
58b2738702 [#1210] morph/GetContractByID: Fix error handling when contract not found 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-06-27 16:31:18 +00:00
achuprov requested review from storage-core-developers 2024-06-27 16:32:48 +00:00
achuprov changed title from morph/GetContractByID: Fix error handling when contract not found to WIP: morph/GetContractByID: Fix error handling when contract not found 2024-06-27 16:49:57 +00:00
fyrchik requested changes 2024-06-27 17:35:56 +00:00
cmd/frostfs-adm/internal/modules/morph/frostfsid/frostfsid.go Outdated
@ -433,2 +433,2 @@
cs, err := r.GetContractByID(1)
if err != nil {
cs, err := helper.GetContractByID(r, 1)
if cs != nil || err != nil {
fyrchik commented 2024-06-27 17:35:47 +00:00
Owner

Why do we need != nil comparison here?

Why do we need `!= nil` comparison here?
cmd/frostfs-adm/internal/modules/morph/helper/util.go Outdated
@ -181,0 +185,4 @@
// However, if the returned state.Contract is nil, it returns an error indicating that the contract was not found.
// See https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1210
func GetContractByID(r *management.ContractReader, id int32) (*state.Contract, error) {
nnsCs, err := r.GetContractByID(id)
fyrchik commented 2024-06-27 17:34:54 +00:00
Owner

It is no nnsCs longer, just cs

It is no `nnsCs` longer, just `cs`
fyrchik commented 2024-06-28 06:47:19 +00:00
Owner

The component in commit seems wrong, should be just adm:

The component in commit seems wrong, should be just `adm:`
achuprov force-pushed bugfix/ftostfd-adm_panic_contact_id from 58b2738702 to e651979c9c 2024-06-28 13:33:41 +00:00 Compare
achuprov force-pushed bugfix/ftostfd-adm_panic_contact_id from e651979c9c to 78e3f4834b 2024-06-28 13:35:49 +00:00 Compare
achuprov changed title from WIP: morph/GetContractByID: Fix error handling when contract not found to morph/GetContractByID: Fix error handling when contract not found 2024-06-28 13:35:52 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 10m2s
Details
Vulncheck / Vulncheck (pull_request) Successful in 11m30s
Details
Build / Build Components (1.21) (pull_request) Successful in 13m28s
Details
Build / Build Components (1.22) (pull_request) Successful in 13m25s
Details
Tests and linters / gopls check (pull_request) Successful in 12m53s
Details
Tests and linters / Lint (pull_request) Successful in 14m47s
Details
Tests and linters / Staticcheck (pull_request) Successful in 14m27s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 17m36s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 18m0s
Details
Tests and linters / Tests with -race (pull_request) Successful in 18m1s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 18m23s
Details
This Pull Request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1211
There is no content yet.
Delete Branch "achuprov/frostfs-node:bugfix/ftostfd-adm_panic_contact_id"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?