TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 90 Pull requests 12 Projects Releases 1 Activity Actions

Pass container owner for backward get method APE-check #1218

Merged
fyrchik merged 3 commits from aarifullin/frostfs-node:fix/bt_get into master 2024-07-03 07:22:19 +00:00
Conversation 0 Commits 3 Files changed 3 +17 -14
aarifullin commented 2024-07-02 10:13:28 +00:00
Member
Copy link

  • object: Pass container owner for backward get method check
    ** getStreamBasicChecker must define containerOwner for backward checks, otherwise bearer token cannot be validated for the token issuer.

  • object: Fix bearer token validation

  • tree: Fix bearer token validation

* object: Pass container owner for backward get method check ** `getStreamBasicChecker` must define `containerOwner` for backward checks, otherwise bearer token cannot be validated for the token issuer. * object: Fix bearer token validation * tree: Fix bearer token validation
aarifullin added the
bug
 label 2024-07-02 10:13:28 +00:00
aarifullin force-pushed fix/bt_get from 8f84f85d90 to 556875dcdd 2024-07-02 10:14:37 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-07-02 10:20:53 +00:00
aarifullin requested review from storage-core-developers 2024-07-02 10:21:16 +00:00
fyrchik reviewed 2024-07-02 11:21:51 +00:00
pkg/services/object/ape/checker.go Outdated
@ -123,3 +124,3 @@
}
// 4. Then check if container owner signed this token.
// 5. Then check if container owner signed this token.
fyrchik commented 2024-07-02 11:21:20 +00:00
Owner
Copy link

Let's remove number all together? The changes on multiple unrelated lines blow up the diff.

Let's remove number all together? The changes on multiple unrelated lines blow up the diff.
fyrchik commented 2024-07-02 11:21:21 +00:00
Owner
Copy link

Let's remove number all together? The changes on multiple unrelated lines blow up the diff.

Let's remove number all together? The changes on multiple unrelated lines blow up the diff.
aarifullin commented 2024-07-02 11:40:56 +00:00
Author
Member
Copy link

Fixed

Fixed
acid-ant approved these changes 2024-07-02 11:22:09 +00:00
aarifullin force-pushed fix/bt_get from 556875dcdd to b02370a789 2024-07-02 11:40:47 +00:00 Compare
aarifullin requested review from acid-ant 2024-07-02 12:29:10 +00:00
dstepanov-yadro approved these changes 2024-07-02 15:56:49 +00:00
fyrchik approved these changes 2024-07-03 05:34:53 +00:00
fyrchik merged commit 4bd4667791 into master 2024-07-03 07:22:19 +00:00
acid-ant approved these changes 2024-07-03 07:28:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1218
No description provided.
Delete branch "aarifullin/frostfs-node:fix/bt_get"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?