engine: Log the error when check object existence #1225

acid-ant · 2024-07-03T14:18:14Z

acid-ant commented

2024-07-03 14:18:14 +00:00

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed bugfix/ext-log-any-shard from 5730a645ba to 257d880098

2024-07-03 14:19:09 +00:00

Compare

acid-ant requested review from storage-core-committers 2024-07-03 14:19:15 +00:00

acid-ant requested review from storage-core-developers 2024-07-03 14:19:39 +00:00

fyrchik reviewed 2024-07-03 18:23:48 +00:00

pkg/local_object_storage/engine/put.go

					
				@ -150,2 +150,4 @@

								// expired => do nothing with it

								res.status = putToShardExists

							} else {

								e.log.Warn(logs.EngineCouldNotCheckObjectExistence,

fyrchik commented

2024-07-03 18:23:45 +00:00

There could be a bunch of logical errors, I think Warn is too much for this error (which can repeat a lot)
What was the problem that you were trying to debug?

There could be a bunch of logical errors, I think `Warn` is too much for this error (which can repeat a lot) What was the problem that you were trying to debug?

acid-ant commented

2024-07-04 06:08:43 +00:00

This is only one place where we skip putting an error in the log. For all other situations, we have an entry with level warn.
Looks like it is not necessary to extend an error could not put object to any shard somehow.

This is only one place where we skip putting an error in the log. For all other situations, we have an entry with level `warn`. Looks like it is not necessary to extend an error `could not put object to any shard` somehow.

👍 1