TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

Unlimited blobovnicza #1226

Merged
fyrchik merged 3 commits from dstepanov-yadro/frostfs-node:feat/unlimited_blobovnicza into master 2024-09-04 19:51:09 +00:00
Conversation 0 Commits 3 Files changed 15 +50 -266
dstepanov-yadro commented 2024-07-04 07:18:43 +00:00
Member
Copy link
  • Drop leaf_width limitation
  • Drop create dbs in advance as now there is no leaf width limit
  • Drop db extension fix at init stage
- Drop `leaf_width` limitation - Drop create dbs in advance as now there is no leaf width limit - Drop db extension fix at init stage
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 3c4cf2e5c0 to 8ec29ba1fc 2024-07-04 07:20:33 +00:00 Compare
fyrchik requested changes 2024-07-04 07:37:51 +00:00
pkg/local_object_storage/blobstor/blobovniczatree/blobovnicza.go Outdated
@ -127,0 +133,4 @@
if len(entries) == 0 {
return false, 0, nil
}
idxs := make([]uint64, 0, len(entries))
fyrchik commented 2024-07-04 07:34:39 +00:00
Owner
Copy link

You create a slice and sort it only to return the maximum.
Why not just search for maximum in a loop?

You create a slice and sort it only to return the maximum. Why not just search for maximum in a loop?
dstepanov-yadro commented 2024-07-04 07:46:57 +00:00
Author
Member
Copy link

Oops, fixed

Oops, fixed
fyrchik marked this conversation as resolved
pkg/local_object_storage/blobstor/blobovniczatree/iterate.go Outdated
@ -131,3 +131,3 @@
levelWidth := b.blzShallowWidth
if isLeafLevel {
levelWidth = b.blzLeafWidth
hasDBs, maxIdx, e := getBlobovniczaMaxIndex(filepath.Join(append([]string{b.rootPath}, curPath...)...))
fyrchik commented 2024-07-04 07:35:23 +00:00
Owner
Copy link

What's wrong with err? It seems we do not shadow anything.

What's wrong with `err`? It seems we do not shadow anything.
dstepanov-yadro commented 2024-07-04 07:47:53 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 8ec29ba1fc to aaad5c1d60 2024-07-04 07:38:10 +00:00 Compare
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from aaad5c1d60 to 7188993c3a 2024-07-04 07:46:29 +00:00 Compare
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 7188993c3a to 6e3e75d0a2 2024-07-04 07:47:15 +00:00 Compare
acid-ant approved these changes 2024-07-04 08:24:06 +00:00
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 6e3e75d0a2 to 62cbb72a5e 2024-07-04 09:22:51 +00:00 Compare
fyrchik approved these changes 2024-07-04 10:54:20 +00:00
fyrchik merged commit 62cbb72a5e into master 2024-07-04 10:55:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1226
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/unlimited_blobovnicza"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?