TrueCloudLab
/
frostfs-node
17
1
Fork 21
Code Issues 88 Pull Requests 9 Actions Projects Releases Activity

Unlimited blobovnicza #1226

Merged
fyrchik merged 3 commits from dstepanov-yadro/frostfs-node:feat/unlimited_blobovnicza into master 2024-07-04 10:55:04 +00:00
Conversation 0 Commits 3 Files Changed 15
dstepanov-yadro commented 2024-07-04 07:18:43 +00:00
Collaborator
  • Drop leaf_width limitation
  • Drop create dbs in advance as now there is no leaf width limit
  • Drop db extension fix at init stage
- Drop `leaf_width` limitation - Drop create dbs in advance as now there is no leaf width limit - Drop db extension fix at init stage
dstepanov-yadro added 3 commits 2024-07-04 07:18:58 +00:00
95eb26d9a3 [#9999] blobovniczatree: Drop init in advance option 
To make blobovniczatree unlimited.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
27ce720c59 [#9999] blobovniczatree: Drop leaf width limitation 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
DCO action / DCO (pull_request) Successful in 3m18s Details
Build / Build Components (1.22) (pull_request) Successful in 6m25s Details
Vulncheck / Vulncheck (pull_request) Successful in 5m40s Details
Build / Build Components (1.21) (pull_request) Successful in 6m31s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 6m31s Details
Tests and linters / gopls check (pull_request) Successful in 8m7s Details
Tests and linters / Staticcheck (pull_request) Successful in 8m12s Details
Tests and linters / Lint (pull_request) Successful in 8m33s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m35s Details
Tests and linters / Tests with -race (pull_request) Successful in 17m25s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 19m15s Details
3c4cf2e5c0 [#9999] blobovniczatree: Delete fix db extensions in Init() 
Since several releases have been released, this code is not relevant.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 3c4cf2e5c0 to 8ec29ba1fc 2024-07-04 07:20:33 +00:00 Compare
fyrchik requested changes 2024-07-04 07:37:51 +00:00
pkg/local_object_storage/blobstor/blobovniczatree/blobovnicza.go Outdated
@ -127,0 +133,4 @@
if len(entries) == 0 {
return false, 0, nil
}
idxs := make([]uint64, 0, len(entries))
fyrchik commented 2024-07-04 07:34:39 +00:00
Owner

You create a slice and sort it only to return the maximum.
Why not just search for maximum in a loop?

You create a slice and sort it only to return the maximum. Why not just search for maximum in a loop?
dstepanov-yadro commented 2024-07-04 07:46:57 +00:00
Poster
Collaborator

Oops, fixed

Oops, fixed
fyrchik marked this conversation as resolved
pkg/local_object_storage/blobstor/blobovniczatree/iterate.go Outdated
@ -131,3 +131,3 @@
levelWidth := b.blzShallowWidth
if isLeafLevel {
levelWidth = b.blzLeafWidth
hasDBs, maxIdx, e := getBlobovniczaMaxIndex(filepath.Join(append([]string{b.rootPath}, curPath...)...))
fyrchik commented 2024-07-04 07:35:23 +00:00
Owner

What's wrong with err? It seems we do not shadow anything.

What's wrong with `err`? It seems we do not shadow anything.
dstepanov-yadro commented 2024-07-04 07:47:53 +00:00
Poster
Collaborator

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 8ec29ba1fc to aaad5c1d60 2024-07-04 07:38:10 +00:00 Compare
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from aaad5c1d60 to 7188993c3a 2024-07-04 07:46:29 +00:00 Compare
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 7188993c3a to 6e3e75d0a2 2024-07-04 07:47:15 +00:00 Compare
acid-ant approved these changes 2024-07-04 08:24:06 +00:00
dstepanov-yadro force-pushed feat/unlimited_blobovnicza from 6e3e75d0a2 to 62cbb72a5e 2024-07-04 09:22:51 +00:00 Compare
fyrchik approved these changes 2024-07-04 10:54:20 +00:00
fyrchik merged commit 62cbb72a5e into master 2024-07-04 10:55:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1226
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:feat/unlimited_blobovnicza"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?