Remove locode package and add frostfs-locode-db dependency #1259

Closed
opened 2024-07-22 08:07:52 +00:00 by george.bartolomey · 0 comments

Expected Behavior

frostfs-node depends on frostfs-locode-db, there is no locode subcommand in frostfs-cli, there is no pkg/util/locode package.

Current Behavior

TrueCloudLab/frostfs-locode-db/pkg/locode is identical to TrueCloudLab/frostfs-node/pkg/util/locode. TrueCloudLab/frostfs-locode-db has frostfs-locode-db CLI utility, and TrueCloudLab/frostfs-node has frostfs-cli util locode subcommand.

Possible Solution

  • Remove pkg/util/locode
  • Remove cmd/frostfs-cli/modules/util/locode*
  • Replace git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode -> git.frostfs.info/TrueCloudLab/frostfs-locode-db/pkg/locode
  • Update go.mod and go.sum
## Expected Behavior frostfs-node depends on frostfs-locode-db, there is no locode subcommand in frostfs-cli, there is no `pkg/util/locode` package. ## Current Behavior `TrueCloudLab/frostfs-locode-db/pkg/locode` is identical to `TrueCloudLab/frostfs-node/pkg/util/locode`. `TrueCloudLab/frostfs-locode-db` has `frostfs-locode-db` CLI utility, and `TrueCloudLab/frostfs-node` has `frostfs-cli util locode` subcommand. ## Possible Solution * Remove `pkg/util/locode` * Remove `cmd/frostfs-cli/modules/util/locode*` * Replace `git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode` -> `git.frostfs.info/TrueCloudLab/frostfs-locode-db/pkg/locode` * Update go.mod and go.sum
george.bartolomey added the
bug
triage
labels 2024-07-22 08:07:52 +00:00
fyrchik added
frostfs-ir
and removed
bug
labels 2024-07-22 08:36:56 +00:00
fyrchik added the
internal
label 2024-07-23 06:13:20 +00:00
fyrchik added this to the v0.43.0 milestone 2024-07-23 07:53:56 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1259
No description provided.