TrueCloudLab/frostfs-node
19
1
Fork 23
Code Issues 97 Pull requests 6 Projects Releases 1 Activity Actions

[#1259] Remove locode package and add frostfs-locode-db dependency #1260

Merged
fyrchik merged 1 commit from george.bartolomey/frostfs-node:locode into master 2024-09-04 19:51:10 +00:00
Conversation 8 Commits 1 Files changed 30 +9 -1985
george.bartolomey commented 2024-07-22 08:21:02 +00:00
Member
Copy link

Moved locode package to frostfs-locode-db repository. frostfs-node will depend on frostfs-locode-db.

  • Removed pkg/util/locode
  • Removed cmd/frostfs-cli/modules/util/locode*
  • Replaced git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode -> git.frostfs.info/TrueCloudLab/frostfs-locode-db/pkg/locode
  • Updated go.mod and go.sum

Closes: #1259

Moved locode package to frostfs-locode-db repository. frostfs-node will depend on frostfs-locode-db. * Removed `pkg/util/locode` * Removed `cmd/frostfs-cli/modules/util/locode*` * Replaced `git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/locode` -> `git.frostfs.info/TrueCloudLab/frostfs-locode-db/pkg/locode` * Updated go.mod and go.sum Closes: #1259
fyrchik requested changes 2024-07-22 08:34:25 +00:00
fyrchik left a comment
Owner
Copy link

Regarding commit messages:

[#1259] Remove locode utility -> [#1259] cli: Remove locode subcommand

Regarding commit messages: `[#1259] Remove locode utility` -> `[#1259] cli: Remove locode subcommand`
go.mod Outdated
@ -35,3 +35,3 @@
github.com/ssgreg/journald v1.0.0
github.com/stretchr/testify v1.9.0
go.etcd.io/bbolt v1.3.9
go.etcd.io/bbolt v1.3.10
fyrchik commented 2024-07-22 08:31:14 +00:00
Owner
Copy link

This dependency is important, it is better not to update it now (separate test needed).

This dependency is important, it is better not to update it now (separate test needed).
george.bartolomey commented 2024-07-22 09:26:14 +00:00
Author
Member
Copy link

Ok, I fixed that.

Ok, I fixed that.
george.bartolomey marked this conversation as resolved
george.bartolomey force-pushed locode from 7a935c6dfa to db705f77c4 2024-07-22 09:25:43 +00:00 Compare
george.bartolomey commented 2024-07-22 09:26:49 +00:00
Author
Member
Copy link

Regarding commit messages:

[#1259] Remove locode utility -> [#1259] cli: Remove locode subcommand

@fyrchik, changed.

> Regarding commit messages: > > `[#1259] Remove locode utility` -> `[#1259] cli: Remove locode subcommand` @fyrchik, changed.
george.bartolomey requested review from fyrchik 2024-07-22 10:53:53 +00:00
fyrchik requested review from storage-core-committers 2024-07-22 11:27:40 +00:00
fyrchik requested review from storage-core-developers 2024-07-22 11:27:52 +00:00
dstepanov-yadro approved these changes 2024-07-22 11:34:31 +00:00
achuprov approved these changes 2024-07-22 11:46:41 +00:00
george.bartolomey force-pushed locode from c8b1a75aea to 381f55f28c 2024-07-22 11:47:52 +00:00 Compare
george.bartolomey commented 2024-07-22 11:48:55 +00:00
Author
Member
Copy link

I fixed conflict with master.

I fixed conflict with master.
fyrchik commented 2024-07-22 11:59:08 +00:00
Owner
Copy link

@george.bartolomey Currently, we are trying to stabilise master branch. The PR looks OK, but I will postpone merging it a bit (will merge in a few days).

@george.bartolomey Currently, we are trying to stabilise master branch. The PR looks OK, but I will postpone merging it a bit (will merge in a few days).
👍 1
fyrchik reviewed 2024-07-22 12:43:14 +00:00
go.mod Outdated
@ -30,3 +30,3 @@
github.com/prometheus/client_golang v1.19.0
github.com/spf13/cast v1.6.0
github.com/spf13/cobra v1.8.0
github.com/spf13/cobra v1.8.1
fyrchik commented 2024-07-22 12:43:07 +00:00
Owner
Copy link

Speaking of other dependencies too -- do you have any specific reason for update?

Speaking of other dependencies too -- do you have any specific reason for update?
george.bartolomey commented 2024-07-22 14:09:59 +00:00
Author
Member
Copy link

go mod tidy changes version of these dependencies.

frostfs-locode-db has newer version of packages. Could we downgrade these packages in frostfs-locode-db module?

`go mod tidy` changes version of these dependencies. frostfs-locode-db has newer version of packages. Could we downgrade these packages in frostfs-locode-db module?
fyrchik commented 2024-07-22 15:28:20 +00:00
Owner
Copy link

ok, not that important, let's leave as is.

ok, not that important, let's leave as is.
👍 1
fyrchik commented 2024-07-22 15:28:50 +00:00
Owner
Copy link

I will update in another PR, let's rebase this one after.

I will update in another PR, let's rebase this one after.
george.bartolomey force-pushed locode from 381f55f28c to 3432bc4351 2024-07-22 14:15:56 +00:00 Compare
aarifullin approved these changes 2024-07-23 06:43:34 +00:00
george.bartolomey force-pushed locode from 3432bc4351 to 92d9f3c4b5 2024-07-23 08:00:26 +00:00 Compare
fyrchik commented 2024-07-23 08:42:53 +00:00
Owner
Copy link

@george.bartolomey #1264 was merged, could you rebase on master, so that I could merge this PR?

@george.bartolomey https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1264 was merged, could you rebase on master, so that I could merge this PR?
👍 1
george.bartolomey force-pushed locode from 92d9f3c4b5 to 4ef96fd068 2024-07-23 09:54:03 +00:00 Compare
george.bartolomey commented 2024-07-23 09:54:53 +00:00
Author
Member
Copy link

@george.bartolomey #1264 was merged, could you rebase on master, so that I could merge this PR?

@fyrchik, done! Please, check.

> @george.bartolomey https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1264 was merged, could you rebase on master, so that I could merge this PR? @fyrchik, done! Please, check.
george.bartolomey force-pushed locode from 4ef96fd068 to f614948671 2024-07-23 11:11:53 +00:00 Compare
fyrchik commented 2024-07-23 11:39:03 +00:00
Owner
Copy link

Please, look at the pre-commit action -- https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9431/jobs/0
It seems go mod tidy needs to be run.

Please, look at the pre-commit action -- https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9431/jobs/0 It seems `go mod tidy` needs to be run.
george.bartolomey force-pushed locode from f614948671 to d3126504e3 2024-07-23 11:58:27 +00:00 Compare
george.bartolomey force-pushed locode from d3126504e3 to 9c2c76ca32 2024-07-23 11:59:38 +00:00 Compare
george.bartolomey commented 2024-07-23 12:00:09 +00:00
Author
Member
Copy link

@fyrchik, fixed.

@fyrchik, fixed.
fyrchik merged commit 9c2c76ca32 into master 2024-07-23 12:56:09 +00:00
fyrchik commented 2024-07-23 12:56:26 +00:00
Owner
Copy link

@george.bartolomey Thanks for your contribution!

@george.bartolomey Thanks for your contribution!
george.bartolomey deleted branch locode 2024-07-23 14:51:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
achuprov
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1260
No description provided.
Delete branch "george.bartolomey/frostfs-node:locode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?