Tests fail with `-count=2` flag #1309

New issue

Closed

opened 2024-08-13 13:12:22 +00:00 by fyrchik · 2 comments

fyrchik commented

2024-08-13 13:12:22 +00:00

Owner

The smallest test seems to be:

--- FAIL: TestGCMemoryLimit (0.00s)
    --- FAIL: TestGCMemoryLimit/defaults (0.00s)
        config_test.go:16:
                Error Trace:    /repo/frostfs/node/cmd/frostfs-node/config/runtime/config_test.go:16
                Error:          Not equal:
                                expected: 9223372036854775807
                                actual  : 1073741824
                Test:           TestGCMemoryLimit/defaults
FAIL
FAIL    git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/config/runtime      0.003s
FAIL

The behaviour is unexpected to say the least.
In this task we need to explain what is the problem and fix it.

The smallest test seems to be: ``` --- FAIL: TestGCMemoryLimit (0.00s) --- FAIL: TestGCMemoryLimit/defaults (0.00s) config_test.go:16: Error Trace: /repo/frostfs/node/cmd/frostfs-node/config/runtime/config_test.go:16 Error: Not equal: expected: 9223372036854775807 actual : 1073741824 Test: TestGCMemoryLimit/defaults FAIL FAIL git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/config/runtime 0.003s FAIL ``` The behaviour is unexpected to say the least. In this task we need to explain what is the problem and fix it.

fyrchik added the

bug

internal

labels 2024-08-13 13:12:27 +00:00

fyrchik added this to the vNext milestone 2024-08-13 13:12:29 +00:00

fyrchik commented

2024-08-13 13:27:07 +00:00

Author

Owner

Most likely it is os.Setenv, we need to remember an use t.Cleanup to clean.

Most likely it is `os.Setenv`, we need to remember an use `t.Cleanup` to clean.

👍 1

fyrchik added the

good first issue

label 2024-08-19 07:36:23 +00:00

a-savchuk was assigned by fyrchik

2024-08-21 12:33:23 +00:00

fyrchik modified the milestone from vNext to v0.43.0

2024-08-21 12:33:25 +00:00

a-savchuk referenced this issue from a pull request that will close it,

2024-08-21 14:17:19 +00:00

test: Fix test failures when running with -count=2 #1327

a-savchuk commented

2024-08-21 14:30:56 +00:00

Member

Most failures were resolved after recent changes, but one persists:

--- FAIL: Test_getOrGenerate (0.61s)
    key_test.go:118: 
                Error Trace:    /repos/frostfs-node/cmd/frostfs-cli/internal/key/key_test.go:118
                                                        /repos/frostfs-node/cmd/frostfs-cli/internal/key/key_test.go:67
                Error:          Target error should be in err chain:
                                expected: "unable to read file from given path"
                                in chain: 
                Test:           Test_getOrGenerate
FAIL
FAIL    git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/key 1.893s
FAIL

Currently working on a fix.

Most failures were resolved after recent changes, but one persists: ``` --- FAIL: Test_getOrGenerate (0.61s) key_test.go:118: Error Trace: /repos/frostfs-node/cmd/frostfs-cli/internal/key/key_test.go:118 /repos/frostfs-node/cmd/frostfs-cli/internal/key/key_test.go:67 Error: Target error should be in err chain: expected: "unable to read file from given path" in chain: Test: Test_getOrGenerate FAIL FAIL git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-cli/internal/key 1.893s FAIL ``` Currently working on a fix.

fyrchik referenced this issue from a commit

2024-08-22 08:49:11 +00:00

[#1309] test: Clean up config after tests

fyrchik closed this issue

2024-08-22 08:49:15 +00:00

fyrchik referenced this issue from a commit

2024-10-30 15:18:23 +00:00

[#1459] .golanci.yml: Add tenv linter, fix issues