TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

test: Fix test failures when running with -count=2 #1327

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-node:bugfix/1309-test-multiple-run into master 2024-08-22 08:49:13 +00:00
Conversation 3 Commits 1 Files changed 2 +11
a-savchuk commented 2024-08-21 14:17:19 +00:00
Member
Copy link

Close #1309

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #1309 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 2 commits 2024-08-21 14:17:31 +00:00 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#1309] frostfs-node/tests: Clean up environment variables after tests
All checks were successful
DCO action / DCO (pull_request) Successful in 1m55s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m42s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m3s
Details
Build / Build Components (1.21) (pull_request) Successful in 2m44s
Details
Build / Build Components (1.22) (pull_request) Successful in 2m42s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m53s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 2m51s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m54s
Details
Tests and linters / Lint (pull_request) Successful in 3m50s
Details
Tests and linters / gopls check (pull_request) Successful in 4m7s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m33s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 3m31s
Details
c1d621d49d 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk changed title from frostfs-node/tests: Fix test failures when running with -count=2 to WIP: frostfs-node/tests: Fix test failures when running with -count=2 2024-08-21 14:21:12 +00:00
acid-ant commented 2024-08-21 17:35:06 +00:00
Member
Copy link

Please remove *: from commit message.

Please remove `*:` from commit message.
👀 1
a-savchuk force-pushed bugfix/1309-test-multiple-run from c1d621d49d to b244e917cc 2024-08-22 06:54:59 +00:00 Compare
a-savchuk force-pushed bugfix/1309-test-multiple-run from b244e917cc to d9e3de9850 2024-08-22 07:07:26 +00:00 Compare
a-savchuk force-pushed bugfix/1309-test-multiple-run from d9e3de9850 to e3d329c780 2024-08-22 07:43:37 +00:00 Compare
a-savchuk force-pushed bugfix/1309-test-multiple-run from e3d329c780 to 5443c62e63 2024-08-22 07:44:34 +00:00 Compare
a-savchuk changed title from WIP: frostfs-node/tests: Fix test failures when running with -count=2 to frostfs-node/tests: Fix test failures when running with -count=2 2024-08-22 07:45:17 +00:00
a-savchuk changed title from frostfs-node/tests: Fix test failures when running with -count=2 to test: Fix test failures when running with -count=2 2024-08-22 07:46:27 +00:00
a-savchuk requested review from storage-core-committers 2024-08-22 07:50:19 +00:00
a-savchuk requested review from storage-core-developers 2024-08-22 07:50:20 +00:00
fyrchik commented 2024-08-22 08:00:36 +00:00
Owner
Copy link

Please, try go test -count=10 -race
We are changing global state, I am a bit concerned about parallel test execution.

Please, try `go test -count=10 -race` We are changing global state, I am a bit concerned about parallel test execution.
👀 1
a-savchuk commented 2024-08-22 08:19:23 +00:00
Author
Member
Copy link

Please, try go test -count=10 -race
We are changing global state, I am a bit concerned about parallel test execution.

Everything is okay.

> Please, try `go test -count=10 -race` > We are changing global state, I am a bit concerned about parallel test execution. Everything is okay.
fyrchik approved these changes 2024-08-22 08:32:03 +00:00
aarifullin approved these changes 2024-08-22 08:46:56 +00:00
fyrchik merged commit dfe825b81b into master 2024-08-22 08:49:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1327
No description provided.
Delete branch "a-savchuk/frostfs-node:bugfix/1309-test-multiple-run"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?