TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 7 Projects Releases 1 Activity Actions

Fix access denied error handling for GET requests #1340

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/get_ape_err_handling into master 2024-08-28 12:15:05 +00:00
Conversation 0 Commits 1 Files changed 3 +29 -12
dstepanov-yadro commented 2024-08-28 11:03:42 +00:00
Member
Copy link
  1. Do not try to get object from remote nodes if local failed with AccessDenied error.
  2. Return AccessDenied error if remote get failed with AccessDenied error.
  3. Send header to output stream again if previous try fail with error.
1. Do not try to get object from remote nodes if local failed with AccessDenied error. 2. Return AccessDenied error if remote get failed with AccessDenied error. 3. Send header to output stream again if previous try fail with error.
dstepanov-yadro added 1 commit 2024-08-28 11:04:18 +00:00
[#1340] getSvc: Fix access denied error handling
All checks were successful
DCO action / DCO (pull_request) Successful in 4m23s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m14s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m33s
Details
Build / Build Components (1.22) (pull_request) Successful in 4m56s
Details
Build / Build Components (1.23) (pull_request) Successful in 4m59s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 5m2s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m6s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 5m8s
Details
Tests and linters / Lint (pull_request) Successful in 5m51s
Details
Tests and linters / gopls check (pull_request) Successful in 6m13s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m19s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m48s
Details
7abbdca064 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
aarifullin approved these changes 2024-08-28 11:07:27 +00:00
acid-ant approved these changes 2024-08-28 11:08:58 +00:00
fyrchik reviewed 2024-08-28 11:56:07 +00:00
pkg/services/object/get/v2/get_forwarder.go
@ -88,3 +88,1 @@
err = f.Stream.WriteHeader(ctx, objectSDK.NewFromV2(obj))
})
if err != nil {
f.headerSentGuard.Lock()
fyrchik commented 2024-08-28 11:56:07 +00:00
Owner
Copy link

Missed this in support branch, could you explain, how is this different from sync.Once?

Missed this in support branch, could you explain, how is this different from `sync.Once`?
dstepanov-yadro commented 2024-08-28 12:02:43 +00:00
Author
Member
Copy link

sync.Once doesn't take err into account: in case of error sync.Once will not run second time.

`sync.Once` doesn't take `err` into account: in case of error `sync.Once` will not run second time.
fyrchik marked this conversation as resolved
fyrchik approved these changes 2024-08-28 12:15:00 +00:00
fyrchik merged commit 7abbdca064 into master 2024-08-28 12:15:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1340
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/get_ape_err_handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?