TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 90 Pull requests 12 Projects Releases 1 Activity Actions

Fix lint errors, update loopvar-related linters #1341

Merged
fyrchik merged 3 commits from fyrchik/frostfs-node:fix-linter into master 2024-08-28 15:44:44 +00:00
Conversation 0 Commits 3 Files changed 18 +5 -32
fyrchik commented 2024-08-28 11:50:34 +00:00
Owner
Copy link
No description provided.
fyrchik added 3 commits 2024-08-28 11:50:39 +00:00 
Fix error with go1.23:
```
Error: build linters: unable to load custom analyzer "truecloudlab-linters": ../linters/bin/external_linters.so, plugin.Open("/repo/frostfs/linters/bin/external_linters"): plugin was built with a different version of package cmp
Failed executing command with error: build linters: unable to load custom analyzer "truecloudlab-linters": ../linters/bin/external_linters.so, plugin.Open("/repo/frostfs/linters/bin/external_linters"): plugin was built with a different version of package cmp
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
.golangci.yml: Replace exportloopref with copyloopvar
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 3m34s
Details
DCO action / DCO (pull_request) Failing after 3m44s
Details
Tests and linters / Lint (pull_request) Failing after 4m46s
Details
Tests and linters / Tests with -race (pull_request) Failing after 4m57s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 5m10s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 5m30s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 5m30s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 6m13s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m51s
Details
Build / Build Components (1.23) (pull_request) Successful in 7m13s
Details
Build / Build Components (1.22) (pull_request) Successful in 7m16s
Details
Tests and linters / gopls check (pull_request) Successful in 6m59s
Details
68d40e37c8 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-08-28 11:50:44 +00:00
fyrchik requested review from storage-core-developers 2024-08-28 11:50:45 +00:00
fyrchik force-pushed fix-linter from 68d40e37c8 to d1dab5aa0b 2024-08-28 11:50:55 +00:00 Compare
fyrchik force-pushed fix-linter from d1dab5aa0b to 2c25f566fd 2024-08-28 11:52:14 +00:00 Compare
fyrchik force-pushed fix-linter from 2c25f566fd to f8c6e05e1c 2024-08-28 12:00:14 +00:00 Compare
aarifullin approved these changes 2024-08-28 13:07:23 +00:00
acid-ant approved these changes 2024-08-28 13:54:23 +00:00
fyrchik merged commit 03976c6ed5 into master 2024-08-28 15:44:44 +00:00
fyrchik deleted branch fix-linter 2024-08-28 15:44:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1341
No description provided.
Delete branch "fyrchik/frostfs-node:fix-linter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?