Update golangci-lint to v1.60 and fix issues #1280

New issue

Closed

opened 2024-07-29 12:47:26 +00:00 by fyrchik · 2 comments

fyrchik commented

2024-07-29 12:47:26 +00:00

Owner

An example, applicable to almost all repositories TrueCloudLab/frostfs-api-go#96

In the frostfs-node we have new warnings from contextcheck linter.
I suggest fixing deprecated configuration fields and creating new tasks for other things.

frostfs-node
frostfs-s3-gw
frostfs-http-gw
frostfs-sdk-go
hrw
tzhash

An example, applicable to almost all repositories https://git.frostfs.info/TrueCloudLab/frostfs-api-go/pulls/96 In the frostfs-node we have new warnings from contextcheck linter. I suggest fixing deprecated configuration fields and creating new tasks for other things. - [x] frostfs-node - [x] frostfs-s3-gw - [x] frostfs-http-gw - [x] frostfs-sdk-go - [ ] hrw - [ ] tzhash

fyrchik added the

triage

label 2024-07-29 12:47:26 +00:00

fyrchik added

and removed

labels 2024-07-29 12:52:22 +00:00

elebedeva was assigned by fyrchik

2024-07-29 12:52:39 +00:00

fyrchik changed title from ~~Update golangci-lint to v1.59 and fix issues~~ to Update golangci-lint to v1.60 and fix issues

2024-08-19 08:24:26 +00:00

fyrchik referenced this issue from a pull request that will close it,

2024-08-21 15:47:46 +00:00

go.mod: Bump go version to 1.22 #1324

fyrchik closed this issue

2024-08-21 17:38:09 +00:00

fyrchik reopened this issue

2024-08-22 10:35:11 +00:00

elebedeva referenced this issue from TrueCloudLab/frostfs-s3-gw

2024-08-22 16:20:12 +00:00

lint: Update golangci-lint to v1.60 and fix issues #474

elebedeva referenced this issue from TrueCloudLab/frostfs-http-gw

2024-08-22 17:42:53 +00:00

lint: Update golangci-lint to v1.60 and fix issues #133

fyrchik commented

2024-08-23 07:54:51 +00:00

Author

Owner

On master, go1.23

Error: build linters: unable to load custom analyzer "truecloudlab-linters": bin/linters/external_linters.so, plugin.Open("/repo/frostfs/node/bin/linters/external_linters"): plugin was built with a different version of package encoding/json
Failed executing command with error: build linters: unable to load custom analyzer "truecloudlab-linters": bin/linters/external_linters.so, plugin.Open("/repo/frostfs/node/bin/linters/external_linters"): plugin was built with a different version of package encoding/json
make: *** [Makefile:204: lint] Error 3

On master, go1.23 ``` Error: build linters: unable to load custom analyzer "truecloudlab-linters": bin/linters/external_linters.so, plugin.Open("/repo/frostfs/node/bin/linters/external_linters"): plugin was built with a different version of package encoding/json Failed executing command with error: build linters: unable to load custom analyzer "truecloudlab-linters": bin/linters/external_linters.so, plugin.Open("/repo/frostfs/node/bin/linters/external_linters"): plugin was built with a different version of package encoding/json make: *** [Makefile:204: lint] Error 3 ```

fyrchik closed this issue

2024-09-10 14:30:28 +00:00

fyrchik commented

2024-09-10 14:31:59 +00:00

Author

Owner

The problem above was fixed in #1341

fyrchik added this to the v0.43.0 milestone 2024-09-10 14:32:05 +00:00