Count errors on the engine level exclusively #1413

Merged

fyrchik merged 1 commit from fyrchik/frostfs-node:counter into master

2024-10-26 11:30:27 +00:00

fyrchik commented

2024-10-04 12:09:58 +00:00

Owner

No functional changes.

fyrchik added 2 commits 2024-10-04 12:09:59 +00:00

engine: Cleanup shard error reporting 903a25bdd7

- `reportShardErrorBackground()` no longer differs from
  `reportShardError()`, reflect this in its name;
- reuse common pieces of code to make it simpler.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

engine: Remove error counting methods from Shard

Tests and linters / Run gofumpt (pull_request) Successful in 1m57s

Details

DCO action / DCO (pull_request) Failing after 2m16s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m30s

Details

Tests and linters / gopls check (pull_request) Successful in 3m33s

Details

Vulncheck / Vulncheck (pull_request) Successful in 3m42s

Details

Tests and linters / Lint (pull_request) Successful in 3m52s

Details

Build / Build Components (pull_request) Successful in 4m42s

Details

Tests and linters / Staticcheck (pull_request) Successful in 4m52s

Details

Tests and linters / Tests (pull_request) Successful in 6m43s

Details

Tests and linters / Tests with -race (pull_request) Successful in 6m50s

Details

322d4cff3b

All error counting and hangling logic is present on the engine level.
Currently, we pass engine metrics with shard ID metric to shard, then
export 3 methods to manipulate these metrics.
In this commits all methods are removed and error counter is tracked on
the engine level exlusively.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>