Count errors on the engine level exclusively #1413

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:counter into master 2024-10-26 11:30:27 +00:00
Owner

No functional changes.

No functional changes.
fyrchik added 2 commits 2024-10-04 12:09:59 +00:00
- `reportShardErrorBackground()` no longer differs from
  `reportShardError()`, reflect this in its name;
- reuse common pieces of code to make it simpler.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
engine: Remove error counting methods from Shard
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 1m57s
DCO action / DCO (pull_request) Failing after 2m16s
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m30s
Tests and linters / gopls check (pull_request) Successful in 3m33s
Vulncheck / Vulncheck (pull_request) Successful in 3m42s
Tests and linters / Lint (pull_request) Successful in 3m52s
Build / Build Components (pull_request) Successful in 4m42s
Tests and linters / Staticcheck (pull_request) Successful in 4m52s
Tests and linters / Tests (pull_request) Successful in 6m43s
Tests and linters / Tests with -race (pull_request) Successful in 6m50s
322d4cff3b
All error counting and hangling logic is present on the engine level.
Currently, we pass engine metrics with shard ID metric to shard, then
export 3 methods to manipulate these metrics.
In this commits all methods are removed and error counter is tracked on
the engine level exlusively.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik requested review from storage-core-committers 2024-10-04 12:10:07 +00:00
fyrchik requested review from storage-core-developers 2024-10-04 12:10:09 +00:00
fyrchik force-pushed counter from 322d4cff3b to 4dc9a1b300 2024-10-04 12:10:24 +00:00 Compare
dstepanov-yadro approved these changes 2024-10-04 12:26:33 +00:00
acid-ant approved these changes 2024-10-04 12:34:01 +00:00
fyrchik merged commit 4dc9a1b300 into master 2024-10-04 12:45:54 +00:00
fyrchik deleted branch counter 2024-10-04 12:45:55 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1413
No description provided.