TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 89 Pull Requests 7 Actions Releases Activity

Make linter stricker #148

Merged
fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:feat/linters into master 2023-07-26 21:07:56 +00:00
Conversation 0 Commits 1 Files Changed 8
dstepanov-yadro commented 2023-03-20 06:42:37 +00:00
Collaborator
There is no content yet.
🎉 1
dstepanov-yadro force-pushed feat/linters from 19ca57e0e4 to 8a21c93e69 2023-03-20 07:31:15 +00:00 Compare
dstepanov-yadro changed title from WIP: Make linter stricker to Make linter stricker 2023-03-20 07:35:05 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-03-20 07:35:17 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-03-20 07:35:22 +00:00
fyrchik reviewed 2023-03-20 07:39:09 +00:00
.golangci.yml Outdated
@ -55,1 +60,4 @@
- whitespace
- containedctx
- funlen
- gocyclo
fyrchik commented 2023-03-20 07:38:12 +00:00
Owner

Do we need both gocyclo and gocognit?
They estimate the same complexity but with different metrics.
What about using gocognit only?

Do we need both gocyclo and gocognit? They estimate the same complexity but with different metrics. What about using `gocognit` only?
dstepanov-yadro commented 2023-03-20 07:42:44 +00:00
Poster
Collaborator

These linters are slightly different: https://github.com/uudashr/gocognit#comparison-with-cyclometic-complexity

i`m ok with using gocognit only

These linters are slightly different: https://github.com/uudashr/gocognit#comparison-with-cyclometic-complexity i`m ok with using gocognit only
dstepanov-yadro commented 2023-03-20 07:55:37 +00:00
Poster
Collaborator

done

done
dstepanov-yadro reviewed 2023-03-20 07:40:08 +00:00
.golangci.yml Outdated
@ -27,2 +27,4 @@
staticcheck:
checks: ["all", "-SA1019"] # TODO Enable SA1019 after deprecated warning are fixed.
funlen:
lines: 80 # default 60
dstepanov-yadro commented 2023-03-20 07:40:08 +00:00
Poster
Collaborator

Function body should fit on one screen. My 24 inch screen holds 40 lines.

Function body should fit on one screen. My 24 inch screen holds 40 lines.
fyrchik commented 2023-03-20 11:29:22 +00:00
Owner

I have seen a research, where it was stated that function's that don't fit on ones screen rapidly decrease developer productivity, so I think 40 lines is a nice goal to have in mind. Let's be honest, not everyone has 4k monitors.

I have seen a research, where it was stated that function's that don't fit on ones screen rapidly decrease developer productivity, so I think 40 lines is a nice goal to have in mind. Let's be honest, not everyone has 4k monitors.
dstepanov-yadro force-pushed feat/linters from 8a21c93e69 to 58a95620a1 2023-03-20 07:55:23 +00:00 Compare
dstepanov-yadro force-pushed feat/linters from 58a95620a1 to 662ac260fa 2023-03-20 07:56:41 +00:00 Compare
fyrchik approved these changes 2023-03-20 11:29:47 +00:00
dstepanov-yadro force-pushed feat/linters from d4f7585cf5 to 60261b0d0a 2023-03-20 12:26:35 +00:00 Compare
fyrchik approved these changes 2023-03-20 13:08:27 +00:00
acid-ant approved these changes 2023-03-20 17:04:00 +00:00
dstepanov-yadro force-pushed feat/linters from 60261b0d0a to 50b92e2019 2023-03-21 06:53:01 +00:00 Compare
dstepanov-yadro force-pushed feat/linters from 50b92e2019 to 44b86bac5a 2023-03-21 06:55:07 +00:00 Compare
fyrchik approved these changes 2023-03-21 06:57:28 +00:00
fyrchik merged commit 44b86bac5a into master 2023-03-21 06:57:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#148
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:feat/linters"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?