Make linter stricker #148

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/linters into master 2023-07-26 21:07:56 +00:00
No description provided.
dstepanov-yadro force-pushed feat/linters from 19ca57e0e4 to 8a21c93e69 2023-03-20 07:31:15 +00:00 Compare
dstepanov-yadro changed title from WIP: Make linter stricker to Make linter stricker 2023-03-20 07:35:05 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-03-20 07:35:17 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-03-20 07:35:22 +00:00
fyrchik reviewed 2023-03-20 07:39:09 +00:00
.golangci.yml Outdated
@ -55,1 +60,4 @@
- whitespace
- containedctx
- funlen
- gocyclo
Owner

Do we need both gocyclo and gocognit?
They estimate the same complexity but with different metrics.
What about using gocognit only?

Do we need both gocyclo and gocognit? They estimate the same complexity but with different metrics. What about using `gocognit` only?
Author
Member

These linters are slightly different: https://github.com/uudashr/gocognit#comparison-with-cyclometic-complexity

i`m ok with using gocognit only

These linters are slightly different: https://github.com/uudashr/gocognit#comparison-with-cyclometic-complexity i`m ok with using gocognit only
Author
Member

done

done
dstepanov-yadro reviewed 2023-03-20 07:40:08 +00:00
.golangci.yml Outdated
@ -27,2 +27,4 @@
staticcheck:
checks: ["all", "-SA1019"] # TODO Enable SA1019 after deprecated warning are fixed.
funlen:
lines: 80 # default 60
Author
Member

Function body should fit on one screen. My 24 inch screen holds 40 lines.

Function body should fit on one screen. My 24 inch screen holds 40 lines.
Owner

I have seen a research, where it was stated that function's that don't fit on ones screen rapidly decrease developer productivity, so I think 40 lines is a nice goal to have in mind. Let's be honest, not everyone has 4k monitors.

I have seen a research, where it was stated that function's that don't fit on ones screen rapidly decrease developer productivity, so I think 40 lines is a nice goal to have in mind. Let's be honest, not everyone has 4k monitors.
dstepanov-yadro force-pushed feat/linters from 8a21c93e69 to 58a95620a1 2023-03-20 07:55:23 +00:00 Compare
dstepanov-yadro force-pushed feat/linters from 58a95620a1 to 662ac260fa 2023-03-20 07:56:41 +00:00 Compare
fyrchik approved these changes 2023-03-20 11:29:47 +00:00
dstepanov-yadro force-pushed feat/linters from d4f7585cf5 to 60261b0d0a 2023-03-20 12:26:35 +00:00 Compare
fyrchik approved these changes 2023-03-20 13:08:27 +00:00
acid-ant approved these changes 2023-03-20 17:04:00 +00:00
dstepanov-yadro force-pushed feat/linters from 60261b0d0a to 50b92e2019 2023-03-21 06:53:01 +00:00 Compare
dstepanov-yadro force-pushed feat/linters from 50b92e2019 to 44b86bac5a 2023-03-21 06:55:07 +00:00 Compare
fyrchik approved these changes 2023-03-21 06:57:28 +00:00
fyrchik merged commit 44b86bac5a into master 2023-03-21 06:57:33 +00:00
fyrchik referenced this pull request from a commit 2023-03-21 06:57:34 +00:00
fyrchik referenced this pull request from a commit 2023-03-21 06:57:34 +00:00
fyrchik referenced this pull request from a commit 2023-03-21 06:57:34 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#148
No description provided.