Await control.SetNetmapStatus() #1496

fyrchik · 2024-11-14T07:27:07Z

fyrchik commented

2024-11-14 07:27:07 +00:00

Currently, netmap set-status awaits until the new status persists in the new network map, i.e. it waits for a new epoch to come.
I see how this can be useful, but here are some quirks:

During testing we would like to make sure that after an epoch tick the status will update. Current --await flag is useless for this scenario.
The old implementation doesn't handle errors at all, so we will wait full timeout, without real necessity. Not to mention that epoch time may vary and 30-min constant we currently use looks magic.

Another option would be to always await the transaction. IMO it would lead to a much cleaner API.
We have already encountered too many flaky tests because of this "not sure when the tx persists" . The tests themselves have timeout kludges.

Currently, `netmap set-status` awaits until the new status persists in the new network map, i.e. it waits for a new epoch to come. I see how this can be useful, but here are some quirks: 1. During testing we would like to make sure that after an epoch tick the status will update. Current `--await` flag is useless for this scenario. 2. The old implementation doesn't handle errors at all, so we will wait full timeout, without real necessity. Not to mention that epoch time may vary and 30-min constant we currently use looks magic. Another option would be to always await the transaction. IMO it would lead to a much cleaner API. We have already encountered too many flaky tests because of this "not sure when the tx persists" . The tests themselves have timeout kludges.

fyrchik added this to the v0.44.0 milestone 2024-11-14 07:27:07 +00:00

fyrchik added the

labels 2024-11-14 07:27:07 +00:00

fyrchik changed title from ~~Allow to await netmap set-status~~ to WIP: Allow to await netmap set-status

2024-11-14 07:28:43 +00:00

requested reviews from storage-core-committers, storage-core-developers

2024-11-14 07:28:58 +00:00

fyrchik changed title from ~~WIP: Allow to await netmap set-status~~ to WIP: cli: Allow to await netmap set-status

2024-11-14 07:30:04 +00:00

fyrchik force-pushed morph-wait-tx from 5cdca40598 to f967af9e3d

2024-11-14 12:10:09 +00:00

Compare

fyrchik changed title from ~~WIP: cli: Allow to await netmap set-status~~ to Await control.SetNetmapStatus()

2024-11-14 12:10:35 +00:00

acid-ant commented

2024-11-15 09:46:17 +00:00

Please update commit messages.

👍 1

acid-ant approved these changes 2024-11-15 09:46:25 +00:00

Dismissed

fyrchik force-pushed morph-wait-tx from f967af9e3d to 1863647a75

2024-11-15 10:37:27 +00:00

Compare

dstepanov-yadro requested changes 2024-11-15 13:24:14 +00:00

Dismissed

pkg/morph/client/waiter.go Outdated

					
				@ -0,0 +36,4 @@

				func (c *Client) WaitTxHalt(ctx context.Context, p InvokeRes) error {

					w, err := waiter.NewPollingBased(&waiterClient{c: c})

					if err != nil {

						return fmt.Errorf("could not create notary deposit waiter: %w", err)