TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 5 Projects Releases 1 Activity Actions

Await control.SetNetmapStatus() #1496

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:morph-wait-tx into master 2024-11-20 15:43:54 +00:00
Conversation 1 Commits 1 Files changed 3 +9 -11
fyrchik commented 2024-11-14 07:27:07 +00:00
Owner
Copy link

Currently, netmap set-status awaits until the new status persists in the new network map, i.e. it waits for a new epoch to come.
I see how this can be useful, but here are some quirks:

  1. During testing we would like to make sure that after an epoch tick the status will update. Current --await flag is useless for this scenario.
  2. The old implementation doesn't handle errors at all, so we will wait full timeout, without real necessity. Not to mention that epoch time may vary and 30-min constant we currently use looks magic.

Another option would be to always await the transaction. IMO it would lead to a much cleaner API.
We have already encountered too many flaky tests because of this "not sure when the tx persists" . The tests themselves have timeout kludges.

Currently, `netmap set-status` awaits until the new status persists in the new network map, i.e. it waits for a new epoch to come. I see how this can be useful, but here are some quirks: 1. During testing we would like to make sure that after an epoch tick the status will update. Current `--await` flag is useless for this scenario. 2. The old implementation doesn't handle errors at all, so we will wait full timeout, without real necessity. Not to mention that epoch time may vary and 30-min constant we currently use looks magic. Another option would be to always await the transaction. IMO it would lead to a much cleaner API. We have already encountered too many flaky tests because of this "not sure when the tx persists" . The tests themselves have timeout kludges.
fyrchik added this to the v0.44.0 milestone 2024-11-14 07:27:07 +00:00
fyrchik added the
enhancement
discussion
frostfs-cli
frostfs-node
 labels 2024-11-14 07:27:07 +00:00
fyrchik added 5 commits 2024-11-14 07:27:08 +00:00 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
WIP: cli: Change --await flag semantics in control set-status
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 1m37s
Details
DCO action / DCO (pull_request) Failing after 1m53s
Details
Tests and linters / Staticcheck (pull_request) Failing after 2m13s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m24s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m17s
Details
Build / Build Components (pull_request) Successful in 2m41s
Details
Tests and linters / Lint (pull_request) Failing after 2m47s
Details
Tests and linters / gopls check (pull_request) Successful in 2m57s
Details
Tests and linters / Tests (pull_request) Successful in 4m31s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m12s
Details
5cdca40598 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik changed title from Allow to await netmap set-status to WIP: Allow to await netmap set-status 2024-11-14 07:28:43 +00:00
fyrchik requested review from storage-core-committers 2024-11-14 07:28:53 +00:00
fyrchik requested review from storage-core-developers 2024-11-14 07:28:58 +00:00
fyrchik changed title from WIP: Allow to await netmap set-status to WIP: cli: Allow to await netmap set-status 2024-11-14 07:30:04 +00:00
fyrchik force-pushed morph-wait-tx from 5cdca40598 to f967af9e3d 2024-11-14 12:10:09 +00:00 Compare
fyrchik changed title from WIP: cli: Allow to await netmap set-status to Await control.SetNetmapStatus() 2024-11-14 12:10:35 +00:00
acid-ant commented 2024-11-15 09:46:17 +00:00
Member
Copy link

Please update commit messages.

Please update commit messages.
👍 1
acid-ant approved these changes 2024-11-15 09:46:25 +00:00
Dismissed
fyrchik force-pushed morph-wait-tx from f967af9e3d to 1863647a75 2024-11-15 10:37:27 +00:00 Compare
dstepanov-yadro requested changes 2024-11-15 13:24:14 +00:00
Dismissed
pkg/morph/client/waiter.go Outdated
@ -0,0 +36,4 @@
func (c *Client) WaitTxHalt(ctx context.Context, p InvokeRes) error {
w, err := waiter.NewPollingBased(&waiterClient{c: c})
if err != nil {
return fmt.Errorf("could not create notary deposit waiter: %w", err)
dstepanov-yadro commented 2024-11-15 13:23:25 +00:00
Member
Copy link

notary deposit waiter -> waiter

`notary deposit waiter` -> `waiter`
fyrchik commented 2024-11-15 13:36:12 +00:00
Author
Owner
Copy link

Fixed

Fixed
fyrchik force-pushed morph-wait-tx from 1863647a75 to d82f0d1926 2024-11-15 13:36:12 +00:00 Compare
fyrchik dismissed acid-ant's review 2024-11-15 13:36:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-11-15 14:12:42 +00:00
dstepanov-yadro approved these changes 2024-11-15 14:25:41 +00:00
fyrchik merged commit d82f0d1926 into master 2024-11-15 15:07:04 +00:00
fyrchik deleted branch morph-wait-tx 2024-11-15 15:07:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.44.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1496
No description provided.
Delete branch "fyrchik/frostfs-node:morph-wait-tx"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?