Consider historic invocations in `list-subjects` command #1518

New issue

Open

opened 2024-11-22 12:30:49 +00:00 by alexvanin · 4 comments

alexvanin commented

2024-11-22 12:30:49 +00:00

Owner

Sometimes we need to get information about already removed subject.

Subject (user) with a name attribute was removed and later admin wants to delete all user's data. To do that, admin is going to list all user's containers and call frostfs-cli control ir remove-container command. To do that, admin needs OwnerID of the user, but it is nowhere to find.

Describe the solution you'd like

Consider adding new flag to frostfs-adm morph frostfsid list-subjects that performs historic invocation from specific block, e.g. --at-block 1234.

In combination with --include-name admin may consider block from the past when user existed and find OwnerID by user name.

Describe alternatives you've considered

To solve the issue, admin may try list all containers, fetch all unique OwnerIDs and find the one which is not presented in FrostFS ID contract, eliminating one by one, without additional changes.

Additional context

None

## Is your feature request related to a problem? Please describe. Sometimes we need to get information about already removed subject. > Subject (user) with a name attribute was removed and later admin wants to delete all user's data. To do that, admin is going to list all user's containers and call `frostfs-cli control ir remove-container` command. To do that, admin needs OwnerID of the user, but it is nowhere to find. ## Describe the solution you'd like Consider adding new flag to `frostfs-adm morph frostfsid list-subjects` that performs historic invocation from specific block, e.g. `--at-block 1234`. In combination with `--include-name` admin may consider block from the past when user existed and find OwnerID by user name. ## Describe alternatives you've considered To solve the issue, admin may try list all containers, fetch all unique OwnerIDs and find the one which is not presented in FrostFS ID contract, eliminating one by one, without additional changes. ## Additional context None

alexvanin added the

discussion

frostfs-adm

triage

labels 2024-11-22 12:30:49 +00:00

alexvanin commented

2024-11-22 12:33:09 +00:00

Author

Owner

Aside from the case, historic invocation for all read operations from smart-contract would be a great addition to frostfs-adm tool, in my opinion.

fyrchik commented

2024-11-22 13:16:05 +00:00

Owner

I believe all our neo-go configurations do store the latest MPT only.

We might support this on the contract level, though (like deletion markers for containers).

I believe all our neo-go configurations do store the latest MPT only. We might support this on the contract level, though (like deletion markers for containers).

👀 1

fyrchik commented

2024-11-22 13:16:56 +00:00

Owner

However, after #1511 we might implement it for local dump scenarios.

However, after https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1511 we might implement it for local dump scenarios.

fyrchik commented

2024-12-25 10:01:42 +00:00

Owner

I suggest having this flag for every command that may invoke something.
NewHistoricInvokerAtHeight should be created using this flag and no other code should be changed.

I suggest having this flag for every command that may invoke something. `NewHistoricInvokerAtHeight` should be created using this flag and no other code should be changed.