TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 5 Projects Releases 1 Activity Actions

WIP: adm: Allow to use local-dump from every command #1511

Draft
fyrchik wants to merge 2 commits from fyrchik/frostfs-node:adm-improve into master
pull from: fyrchik/frostfs-node:adm-improve
merge into: TrueCloudLab:master
Conversation 0 Commits 2 Files changed 26 +121 -122
fyrchik commented 2024-11-20 11:32:29 +00:00
Owner
Copy link

Currently, we allow using --local-dump in morph init command.
We also have this flag in other commands, but no --protocol which is
also needed. And in new command we do not have the ability to use local
dump at all.

This commit makes it possible to work either with an RPC or with
local-dump in every command.

Refs #1035.
Refs TrueCloudLab/frostfs-dev-env#42.

Writing gopatch this time was really satisfying, btw:

@@
var flags expression
@@
-flags.StringP(commonflags.EndpointFlag, ...)
+commonflags.InitRPC(flags)

@@
var flags expression
@@
-_ = viper.BindPFlag(commonflags.EndpointFlag, flags.Lookup(...))
+commonflags.BindRPC(flags)
Currently, we allow using `--local-dump` in `morph init` command. We also have this flag in other commands, but no `--protocol` which is also needed. And in new command we do not have the ability to use local dump at all. This commit makes it possible to work either with an RPC or with local-dump in every command. Refs #1035. Refs TrueCloudLab/frostfs-dev-env#42. Writing gopatch this time was really satisfying, btw: ``` @@ var flags expression @@ -flags.StringP(commonflags.EndpointFlag, ...) +commonflags.InitRPC(flags) @@ var flags expression @@ -_ = viper.BindPFlag(commonflags.EndpointFlag, flags.Lookup(...)) +commonflags.BindRPC(flags) ```
fyrchik added 3 commits 2024-11-20 11:32:30 +00:00
adm: Move ProtoConfigPath from constants to commonflags package
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 1m48s
Details
DCO action / DCO (pull_request) Failing after 2m14s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m34s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m44s
Details
Build / Build Components (pull_request) Successful in 3m8s
Details
Tests and linters / gopls check (pull_request) Successful in 3m13s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m33s
Details
Tests and linters / Lint (pull_request) Successful in 4m17s
Details
Tests and linters / Tests (pull_request) Successful in 4m57s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m36s
Details
70f77a53d9 
Refs #932

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
adm: Allow to use --local-dump everywhere --rpc-endpoint is present
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 2m37s
Details
DCO action / DCO (pull_request) Failing after 2m53s
Details
Build / Build Components (pull_request) Successful in 4m9s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m15s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m0s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m54s
Details
Tests and linters / Lint (pull_request) Successful in 5m7s
Details
Tests and linters / gopls check (pull_request) Successful in 6m27s
Details
Tests and linters / Tests (pull_request) Successful in 8m21s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m28s
Details
39e3339df6 
Currently, we allow using `--local-dump` in `morph init` command.
We also have this flag in other commands, but no `--protocol` which is
also needed. And in new command we do not have the ability to use local
dump at all.

This commit makes it possible to work either with an RPC or with
local-dump in every command.

Refs #1035.
Refs TrueCloudLab/frostfs-dev-env#42.

Writing gopatch this time was really satisfying, btw:
```
@@
var flags expression
@@

-flags.StringP(commonflags.EndpointFlag, ...)
+commonflags.InitRPC(flags)

@@
var flags expression
@@
-_ = viper.BindPFlag(commonflags.EndpointFlag, flags.Lookup(...))
+commonflags.BindRPC(flags)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik force-pushed adm-improve from 39e3339df6 to 08f197c905 2024-11-20 11:32:50 +00:00 Compare
fyrchik requested review from storage-core-committers 2024-11-20 11:32:50 +00:00
fyrchik requested review from storage-core-developers 2024-11-20 11:32:53 +00:00
fyrchik force-pushed adm-improve from 08f197c905 to 53c2a96258 2024-11-20 11:38:06 +00:00 Compare
fyrchik force-pushed adm-improve from 53c2a96258 to e82f79b0a8 2024-11-20 11:38:39 +00:00 Compare
fyrchik changed title from adm: Allow to use local-dump from every command to WIP: adm: Allow to use local-dump from every command 2024-11-20 11:40:35 +00:00
dstepanov-yadro approved these changes 2024-11-20 12:27:54 +00:00
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 3m21s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m10s
Required
Details
Tests and linters / Tests (pull_request) Successful in 4m16s
Required
Details
DCO action / DCO (pull_request) Failing after 4m29s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 5m44s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m13s
Required
Details
Build / Build Components (pull_request) Successful in 6m23s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m25s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 6m27s
Required
Details
Tests and linters / Lint (pull_request) Successful in 7m27s
Required
Details
This pull request has changes conflicting with the target branch.
  • cmd/frostfs-adm/internal/modules/morph/initialize/root.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u adm-improve:fyrchik-adm-improve
git checkout fyrchik-adm-improve
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1511
No description provided.
Delete branch "fyrchik/frostfs-node:adm-improve"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?