TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 105 Pull requests 4 Projects Releases 2 Packages 4 Activity Actions

docs: Fix description of shard switching mode #1645

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:bugfix/fix_shard_docs into master 2025-03-21 12:13:04 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -4
achuprov commented 2025-02-12 16:39:24 +00:00
Member
Copy link

Close #1294
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1294 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2025-02-12 16:39:25 +00:00
[#1294] docs: Fix description of shard switching mode
All checks were successful
DCO action / DCO (pull_request) Successful in 44s
Details
Vulncheck / Vulncheck (pull_request) Successful in 53s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m29s
Details
Build / Build Components (pull_request) Successful in 1m34s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m0s
Details
Tests and linters / Tests (pull_request) Successful in 2m8s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m9s
Details
Tests and linters / gopls check (pull_request) Successful in 3m1s
Details
Tests and linters / Lint (pull_request) Successful in 3m11s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m52s
Details
8f070d8095 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-12 16:39:25 +00:00
acid-ant approved these changes 2025-02-13 06:07:55 +00:00
Dismissed
a-savchuk approved these changes 2025-02-13 08:21:10 +00:00
Dismissed
elebedeva approved these changes 2025-02-13 10:40:14 +00:00
Dismissed
dstepanov-yadro requested changes 2025-02-17 06:31:05 +00:00
docs/shard-modes.md Outdated
@ -56,3 +56,4 @@
2. If shard error counter exceeds threshold.
3. If the metabase couldn't be reopened during SIGHUP handling.
If switching to `read-only` is impossible, the shard will switch to `degraded-read-only`.
dstepanov-yadro commented 2025-02-17 06:31:03 +00:00
Member
Copy link

It is not true, see

Line 90 in fe0cf86
func (e *StorageEngine) moveToDegraded(ctx context.Context, sh *shard.Shard, errCount uint32, isMeta bool) {

It is not true, see https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/fe0cf86dc681e221706d9dcb4b25413bfdf065e9/pkg/local_object_storage/engine/engine.go#L90
achuprov force-pushed bugfix/fix_shard_docs from 8f070d8095 to 4c6a3ba0fc 2025-02-17 09:41:57 +00:00 Compare
achuprov dismissed acid-ant's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed a-savchuk's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed elebedeva's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aarifullin reviewed 2025-02-18 09:01:51 +00:00
docs/shard-modes.md Outdated
@ -53,3 +53,3 @@
Shard can automatically switch to a `degraded-read-only` mode in 3 cases:
Shard can automatically switch to a `read-only` mode in 3 cases:
1. If the metabase was not available or couldn't be opened/initialized during shard startup.
aarifullin commented 2025-02-18 09:01:51 +00:00
Member
Copy link

That's not true for 1.

That's not true for 1.
achuprov commented 2025-03-04 16:49:00 +00:00
Author
Member
Copy link

Ok, only point 2 is left .

Ok, only [point](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/4685afb1dc5737a70833231031582fda29476835/pkg/local_object_storage/engine/engine.go#L158) 2 is left .
achuprov force-pushed bugfix/fix_shard_docs from 4c6a3ba0fc to 5a25fb4594 2025-03-04 16:42:55 +00:00 Compare
achuprov force-pushed bugfix/fix_shard_docs from 5a25fb4594 to ae64e09ead 2025-03-04 16:43:22 +00:00 Compare
achuprov changed title from [#1294] docs: Fix description of shard switching mode to docs: Fix description of shard switching mode 2025-03-04 16:43:45 +00:00
fyrchik merged commit d951289131 into master 2025-03-21 12:13:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1645
No description provided.
Delete branch "achuprov/frostfs-node:bugfix/fix_shard_docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?