[#1294] docs: Fix description of shard switching mode #1645

Open
achuprov wants to merge 1 commit from achuprov/frostfs-node:bugfix/fix_shard_docs into master
Member

Close #1294
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1294 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2025-02-12 16:39:25 +00:00
[#1294] docs: Fix description of shard switching mode
All checks were successful
DCO action / DCO (pull_request) Successful in 44s
Vulncheck / Vulncheck (pull_request) Successful in 53s
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m29s
Build / Build Components (pull_request) Successful in 1m34s
Tests and linters / Run gofumpt (pull_request) Successful in 2m0s
Tests and linters / Tests (pull_request) Successful in 2m8s
Tests and linters / Staticcheck (pull_request) Successful in 2m9s
Tests and linters / gopls check (pull_request) Successful in 3m1s
Tests and linters / Lint (pull_request) Successful in 3m11s
Tests and linters / Tests with -race (pull_request) Successful in 3m52s
8f070d8095
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-12 16:39:25 +00:00
acid-ant approved these changes 2025-02-13 06:07:55 +00:00
Dismissed
a-savchuk approved these changes 2025-02-13 08:21:10 +00:00
Dismissed
elebedeva approved these changes 2025-02-13 10:40:14 +00:00
Dismissed
dstepanov-yadro requested changes 2025-02-17 06:31:05 +00:00
@ -56,3 +56,4 @@
2. If shard error counter exceeds threshold.
3. If the metabase couldn't be reopened during SIGHUP handling.
If switching to `read-only` is impossible, the shard will switch to `degraded-read-only`.

It is not true, see

func (e *StorageEngine) moveToDegraded(ctx context.Context, sh *shard.Shard, errCount uint32, isMeta bool) {

It is not true, see https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/fe0cf86dc681e221706d9dcb4b25413bfdf065e9/pkg/local_object_storage/engine/engine.go#L90
achuprov force-pushed bugfix/fix_shard_docs from 8f070d8095 to 4c6a3ba0fc 2025-02-17 09:41:57 +00:00 Compare
achuprov dismissed acid-ant's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed a-savchuk's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

achuprov dismissed elebedeva's review 2025-02-17 09:41:57 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

aarifullin reviewed 2025-02-18 09:01:51 +00:00
@ -53,3 +53,3 @@
Shard can automatically switch to a `degraded-read-only` mode in 3 cases:
Shard can automatically switch to a `read-only` mode in 3 cases:
1. If the metabase was not available or couldn't be opened/initialized during shard startup.
Member

That's not true for 1.

That's not true for 1.
All checks were successful
DCO action / DCO (pull_request) Successful in 41s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 54s
Required
Details
Build / Build Components (pull_request) Successful in 1m27s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m28s
Required
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m35s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m57s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m33s
Required
Details
Tests and linters / Lint (pull_request) Successful in 2m41s
Required
Details
Tests and linters / Tests (pull_request) Successful in 2m57s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 3m16s
Required
Details
This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u bugfix/fix_shard_docs:achuprov-bugfix/fix_shard_docs
git checkout achuprov-bugfix/fix_shard_docs
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1645
No description provided.