Syncrhonize pre-commit settings across FrostFS repos #171

Merged

realloc merged 1 commit from alexvanin/frostfs-node:pre-commit-sync into master

2023-07-26 21:07:56 +00:00

alexvanin commented

2023-03-24 07:43:27 +00:00

Owner

This change allows to use [#xx] placeholders for issue number.
This change adds go unit test run if .go files were changed.

$ git commit -m "[#xx] Foo"
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check that executables have shebangs.................(no files to check)Skipped
check that scripts with shebangs are executable..........................Passed
check for merge conflicts................................................Passed
check json...........................................(no files to check)Skipped
check xml............................................(no files to check)Skipped
check yaml...........................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
shellcheck...........................................(no files to check)Skipped
golangci-lint............................................................Passed
go unit tests............................................................Failed
- hook id: go-unit-tests
- exit code: 2

⇒ Running go test
...
--- FAIL: TestSaltWriter_Write (0.00s)
    salt_test.go:28: 
                Error Trace:    /home/alexvanin/Project/FrostFS/frostfs-node/pkg/util/salt_test.go:28
                Error:          An error is expected but got nil.
                Test:           TestSaltWriter_Write
FAIL
FAIL    git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util     0.003s
ok      git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/attributes  0.004s
...

This change allows to use `[#xx]` placeholders for issue number. This change adds go unit test run if .go files were changed. ``` $ git commit -m "[#xx] Foo" check for added large files..............................................Passed check for case conflicts.................................................Passed check that executables have shebangs.................(no files to check)Skipped check that scripts with shebangs are executable..........................Passed check for merge conflicts................................................Passed check json...........................................(no files to check)Skipped check xml............................................(no files to check)Skipped check yaml...........................................(no files to check)Skipped trim trailing whitespace.................................................Passed fix end of files.........................................................Passed shellcheck...........................................(no files to check)Skipped golangci-lint............................................................Passed go unit tests............................................................Failed - hook id: go-unit-tests - exit code: 2 ⇒ Running go test ... --- FAIL: TestSaltWriter_Write (0.00s) salt_test.go:28: Error Trace: /home/alexvanin/Project/FrostFS/frostfs-node/pkg/util/salt_test.go:28 Error: An error is expected but got nil. Test: TestSaltWriter_Write FAIL FAIL git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util 0.003s ok git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/attributes 0.004s ... ```

alexvanin self-assigned this 2023-03-24 07:43:27 +00:00

alexvanin force-pushed pre-commit-sync from cd6db8e5e7 to d857ffeb2e

2023-03-24 07:44:07 +00:00

Compare

alexvanin requested review from storage-core-committers 2023-03-24 07:46:10 +00:00

alexvanin requested review from storage-core-developers 2023-03-24 07:46:10 +00:00

realloc commented

2023-03-24 07:46:12 +00:00

Owner

Let's drop unit test run from CI pipeline to avoid doing same thing twice.

alexvanin changed title from ~~WIP: Syncrhonize pre-commit settings across FrostFS repos~~ to Syncrhonize pre-commit settings across FrostFS repos

2023-03-24 07:46:17 +00:00

alexvanin added 1 commit 2023-03-24 07:50:22 +00:00

[#171 ] Remove unit tests from pipeline

ci/woodpecker/push/pre-commit Pipeline was successful

Details

9ffa0d8fea

Unit tests are included as pre-commit hook. They are
triggered by the change of .go files.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

alexvanin commented

2023-03-24 07:51:26 +00:00

Author

Owner

@realloc see 9ffa0d8fea

Also it seems that woodpecker CI won't start new runs on this PR unless initial run (https://ci.frostfs.info/TrueCloudLab/frostfs-node/build/58) is finished.

@realloc see https://git.frostfs.info/TrueCloudLab/frostfs-node/commit/9ffa0d8fead0fbaa0efff3d37a411b061cea06fd Also it seems that woodpecker CI won't start new runs on this PR unless initial run (https://ci.frostfs.info/TrueCloudLab/frostfs-node/build/58) is finished.

realloc approved these changes 2023-03-24 07:55:46 +00:00