[#308] Remove downloadContractsFromGithub from the frostfs-adm #315
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#315
Loading…
Reference in a new issue
No description provided.
Delete branch "ale64bit/frostfs-node:fix/308-remove-gh-download"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Signed-off-by: Alejandro Lopez a.lopez@yadro.com
Close #308
@ -8,4 +0,0 @@
"net/http"
"strings"
"github.com/google/go-github/v39/github"
Hm, do we still have dependency in go.mod after
go mod tidy
?fixed. Good catch, maybe a good candidate for the precommit linters.
#317
6a2e76e4a0
to7a49f6e07a
@ -403,3 +403,2 @@
if c.ContractPath == "" {
c.Command.Println("Contracts flag is missing, latest release will be fetched from Github.")
r, err = downloadContractsFromGithub(c.Command)
return errors.New("contracts flag is missing")
Mark is as required on a cobra level?
done
7a49f6e07a
tod1661ae7dc