[#308] Remove downloadContractsFromGithub from the frostfs-adm #315

Merged
fyrchik merged 1 commit from ale64bit/frostfs-node:fix/308-remove-gh-download into master 2023-05-04 12:08:38 +00:00
Member

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Close #308

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #308
ale64bit requested review from storage-core-committers 2023-05-04 08:02:27 +00:00
ale64bit requested review from storage-core-developers 2023-05-04 08:02:27 +00:00
fyrchik reviewed 2023-05-04 08:03:35 +00:00
@ -8,4 +0,0 @@
"net/http"
"strings"
"github.com/google/go-github/v39/github"
Owner

Hm, do we still have dependency in go.mod after go mod tidy?

Hm, do we still have dependency in go.mod after `go mod tidy`?
Author
Member

fixed. Good catch, maybe a good candidate for the precommit linters.

fixed. Good catch, maybe a good candidate for the precommit linters.
Owner
https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/317
ale64bit force-pushed fix/308-remove-gh-download from 6a2e76e4a0 to 7a49f6e07a 2023-05-04 08:09:13 +00:00 Compare
acid-ant approved these changes 2023-05-04 08:10:07 +00:00
fyrchik reviewed 2023-05-04 10:52:06 +00:00
@ -403,3 +403,2 @@
if c.ContractPath == "" {
c.Command.Println("Contracts flag is missing, latest release will be fetched from Github.")
r, err = downloadContractsFromGithub(c.Command)
return errors.New("contracts flag is missing")
Owner

Mark is as required on a cobra level?

Mark is as required on a cobra level?
Author
Member

done

done
fyrchik approved these changes 2023-05-04 10:52:09 +00:00
ale64bit force-pushed fix/308-remove-gh-download from 7a49f6e07a to d1661ae7dc 2023-05-04 11:08:52 +00:00 Compare
fyrchik merged commit d1661ae7dc into master 2023-05-04 12:08:38 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#315
No description provided.