[#308] Remove downloadContractsFromGithub from the frostfs-adm #315

ale64bit · 2023-05-04T08:02:12Z

ale64bit commented

2023-05-04 08:02:12 +00:00

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Close #308

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #308

ale64bit requested review from storage-core-committers 2023-05-04 08:02:27 +00:00

ale64bit requested review from storage-core-developers 2023-05-04 08:02:27 +00:00

fyrchik reviewed 2023-05-04 08:03:35 +00:00

cmd/frostfs-adm/internal/modules/morph/download.go Outdated

													
				@ -8,4 +0,0 @@

					"net/http"

					"strings"

					"github.com/google/go-github/v39/github"

fyrchik commented

2023-05-04 08:03:35 +00:00

Hm, do we still have dependency in go.mod after go mod tidy?

Hm, do we still have dependency in go.mod after `go mod tidy`?

ale64bit commented

2023-05-04 08:09:40 +00:00

Poster

fixed. Good catch, maybe a good candidate for the precommit linters.

fyrchik commented

2023-05-04 10:51:14 +00:00

#317

https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/317

ale64bit force-pushed fix/308-remove-gh-download from 6a2e76e4a0 to 7a49f6e07a

2023-05-04 08:09:13 +00:00

Compare

acid-ant approved these changes 2023-05-04 08:10:07 +00:00

fyrchik reviewed 2023-05-04 10:52:06 +00:00

cmd/frostfs-adm/internal/modules/morph/initialize_deploy.go Outdated

													
				@ -403,3 +403,2 @@

						if c.ContractPath == "" {

							c.Command.Println("Contracts flag is missing, latest release will be fetched from Github.")

							r, err = downloadContractsFromGithub(c.Command)

							return errors.New("contracts flag is missing")