Packaging: allow any version #36

carpawell · 2023-01-30T09:28:36Z

DmitryZabolotsky commented

2023-01-30 09:28:36 +00:00

(Migrated from github.com)

Close #36

Also updated changelog

Close #36 Also updated changelog

carpawell (Migrated from github.com) reviewed 2023-01-30 09:28:36 +00:00

acid-ant (Migrated from github.com) reviewed 2023-01-30 09:35:58 +00:00

realloc commented

2023-01-30 10:17:04 +00:00

(Migrated from github.com)

This would cause each package to be marked as -dirty. AFAIR, previously we agreed to carefully set version corresponding to a particular release to avoid false dirty builds.

fyrchik (Migrated from github.com) reviewed 2023-01-31 08:23:54 +00:00

debian/changelog

					
				@ -1,18 +1,5 @@

				frostfs-node (0.34.0~97-dirty~g42554a92-jammy) jammy; urgency=medium

				frostfs-node (0.0.1) stable; urgency=medium

fyrchik (Migrated from github.com) commented

2023-01-31 08:23:54 +00:00

When do we need to change this number? Every release of a frostfs-node? On every non-compatible change?

realloc (Migrated from github.com) reviewed 2023-01-31 08:35:07 +00:00

debian/changelog

					
				@ -1,18 +1,5 @@

				frostfs-node (0.34.0~97-dirty~g42554a92-jammy) jammy; urgency=medium

				frostfs-node (0.0.1) stable; urgency=medium

realloc (Migrated from github.com) commented

2023-01-31 08:35:07 +00:00

Each package build must have package version to be the same as one reported by --version from cli.

Each package build must have package version to be the same as one reported by `--version` from cli.

alexvanin (Migrated from github.com) approved these changes 2023-01-31 13:23:58 +00:00

alexvanin (Migrated from github.com) left a comment

This change is required to use latest FrostFS version in CI pipeline (speicifcally -b key in dch command to force build). So it would be nice to merge it soon.

This change is required to use latest FrostFS version in CI pipeline (speicifcally `-b` key in `dch` command to force build). So it would be nice to merge it soon.

realloc (Migrated from github.com) approved these changes 2023-01-31 13:29:18 +00:00

realloc (Migrated from github.com) left a comment

Did this fix the dirty suffix in the resulting binary inside package?

acid-ant (Migrated from github.com) approved these changes 2023-01-31 13:29:31 +00:00

carpawell referenced this pull request from a commit

2023-03-22 17:36:30 +00:00

[#36] Packaging: allow any version

Sign in to join this conversation.

No reviewers

carpawell

alexvanin

realloc