TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

Packaging: allow any version #36

Merged
DmitryZabolotsky merged 1 commits from misc/allow-any-package-versions into master 2023-07-26 21:07:56 +00:00
Conversation 1 Commits 1 Files Changed 3
DmitryZabolotsky commented 2023-01-30 09:28:36 +00:00 (Migrated from github.com)

Close #36

Also updated changelog

Close #36 Also updated changelog
carpawell (Migrated from github.com) reviewed 2023-01-30 09:28:36 +00:00
acid-ant (Migrated from github.com) reviewed 2023-01-30 09:35:58 +00:00
realloc commented 2023-01-30 10:17:04 +00:00 (Migrated from github.com)

This would cause each package to be marked as -dirty. AFAIR, previously we agreed to carefully set version corresponding to a particular release to avoid false dirty builds.

This would cause each package to be marked as -dirty. AFAIR, previously we agreed to carefully set version corresponding to a particular release to avoid false dirty builds.
fyrchik (Migrated from github.com) reviewed 2023-01-31 08:23:54 +00:00
debian/changelog
@ -1,18 +1,5 @@
frostfs-node (0.34.0~97-dirty~g42554a92-jammy) jammy; urgency=medium
frostfs-node (0.0.1) stable; urgency=medium
fyrchik (Migrated from github.com) commented 2023-01-31 08:23:54 +00:00

When do we need to change this number? Every release of a frostfs-node? On every non-compatible change?

When do we need to change this number? Every release of a frostfs-node? On every non-compatible change?
realloc (Migrated from github.com) reviewed 2023-01-31 08:35:07 +00:00
debian/changelog
@ -1,18 +1,5 @@
frostfs-node (0.34.0~97-dirty~g42554a92-jammy) jammy; urgency=medium
frostfs-node (0.0.1) stable; urgency=medium
realloc (Migrated from github.com) commented 2023-01-31 08:35:07 +00:00

Each package build must have package version to be the same as one reported by --version from cli.

Each package build must have package version to be the same as one reported by `--version` from cli.
alexvanin (Migrated from github.com) approved these changes 2023-01-31 13:23:58 +00:00
alexvanin (Migrated from github.com) left a comment

This change is required to use latest FrostFS version in CI pipeline (speicifcally -b key in dch command to force build). So it would be nice to merge it soon.

This change is required to use latest FrostFS version in CI pipeline (speicifcally `-b` key in `dch` command to force build). So it would be nice to merge it soon.
realloc (Migrated from github.com) approved these changes 2023-01-31 13:29:18 +00:00
realloc (Migrated from github.com) left a comment

Did this fix the dirty suffix in the resulting binary inside package?

Did this fix the dirty suffix in the resulting binary inside package?
acid-ant (Migrated from github.com) approved these changes 2023-01-31 13:29:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carpawell
alexvanin
realloc
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#36
There is no content yet.
Delete Branch "misc/allow-any-package-versions"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?