Improve tree service support in CLI #390

New issue

Closed

opened 2023-05-25 09:47:04 +00:00 by alexvanin · 2 comments

alexvanin commented

2023-05-25 09:47:04 +00:00

Owner

FrostFS CLI supports tree service operations, see tree section. It does not implement some API features, which can be quite useful.

Describe the solution you'd like

Support bearer token

Gateways access tree service of private containers by using bearer token, to replace deny rules of extended ACL table with allow rules. CLI does not allow to attach bearer token.

Cover all protocol methods in the CLI

Current CLI implementation allows to invoke:

Add
AddByPath
GetByPath
TreeList

There are a couple more methods client can use:

Remove
Move
GetSubTree
Healthcheck

There are two more which are not used by the clients, so reconsider adding them in the CLI.

Apply
GetOpLog

Describe alternatives you've considered

None.

Additional context

None.

## Is your feature request related to a problem? Please describe. FrostFS CLI supports tree service operations, see `tree` section. It does not implement some API features, which can be quite useful. ## Describe the solution you'd like #### Support bearer token Gateways access tree service of private containers by using bearer token, to replace deny rules of extended ACL table with allow rules. CLI does not allow to attach bearer token. #### Cover all protocol methods in the CLI Current CLI implementation allows to invoke: - Add - AddByPath - GetByPath - TreeList There are a couple more methods client can use: - [ ] Remove - [ ] Move - [ ] GetSubTree - [ ] Healthcheck There are two more which are not used by the clients, so reconsider adding them in the CLI. - [ ] Apply - [ ] GetOpLog ## Describe alternatives you've considered None. ## Additional context None.

alexvanin added the

enhancement

frostfs-cli

triage

labels 2023-05-25 09:47:04 +00:00

alexvanin commented

2023-05-25 10:08:57 +00:00

Author

Owner

I think we wanted to do (1) back in the days, according to this code:

BearerToken: nil, // TODO: #1891 add token handling

	req.Body = &tree.GetNodeByPathRequest_Body{
		...
		BearerToken:   nil, // TODO: #1891 add token handling
	}

I think we wanted to do (1) back in the days, according to this code: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/a1823423cf238d9c8634111fd9203e8c1f8aa940/cmd/frostfs-cli/modules/tree/get_by_path.go#L74 ```go req.Body = &tree.GetNodeByPathRequest_Body{ ... BearerToken: nil, // TODO: #1891 add token handling } ```