Possible problems with XHeader processing #465

New issue

Open

opened 2023-06-26 11:32:09 +00:00 by fyrchik · 0 comments

fyrchik commented

2023-06-26 11:32:09 +00:00

Owner

We don't set netmap epoch XHeader for auxiliary queries in the object service

// FIXME: (neofs-node#1194) not supported by client

However, it seems we set it impliticly via the x-headers. It is a problem:

The code doesn't do what it is supposed to be doing.
Suddely all our operations become exponential in complexity netmap_depth ^ TTL (first node searches at epochs N..N-D+1, another nodes searches N..N-D+1, N-1..N-D etc.), because XHeaders are being sent unchanged.

API description is vague

// Netmap epoch to use for object placement calculation. The `value` is string

Let's discuss and fix the behaviour.
cc @alexvanin @realloc

We don't set netmap epoch XHeader for auxiliary queries in the object service https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/71a63b8e9c629fb7efb5343e108995296df97ed3/pkg/services/object/internal/client/client.go#L84 However, it seems we set it _impliticly_ via the x-headers. It is a problem: 1. The code doesn't do what it is supposed to be doing. 2. Suddely all our operations become exponential in complexity `netmap_depth ^ TTL` (first node searches at epochs N..N-D+1, another nodes searches N..N-D+1, N-1..N-D etc.), because XHeaders are being sent unchanged. API description is vague https://git.frostfs.info/TrueCloudLab/frostfs-api/src/commit/dbfa9c944bd7486f96daad3090cad6c238e9f833/session/types.proto#L145 Let's discuss and fix the behaviour. cc @alexvanin @realloc