TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 13 Projects Releases 2 Activity Actions

objsvc: Set NETMAP_EPOCH xheader for auxiliary requests #1580

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:xheaders into master 2024-12-26 09:17:59 +00:00
Conversation 0 Commits 1 Files changed 1 +20 -8
fyrchik commented 2024-12-25 09:06:05 +00:00
Owner
Copy link

Close #465

Close #465
fyrchik added 1 commit 2024-12-25 09:06:05 +00:00
[#465] objsvc: Set NETMAP_EPOCH xheader for auxiliary requests
All checks were successful
DCO action / DCO (pull_request) Successful in 3m47s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m8s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m31s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m32s
Details
Build / Build Components (pull_request) Successful in 5m23s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m40s
Details
Tests and linters / gopls check (pull_request) Successful in 5m43s
Details
Tests and linters / Tests (pull_request) Successful in 6m14s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m9s
Details
Tests and linters / Lint (pull_request) Successful in 6m34s
Details
683d2ed771 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2024-12-25 09:06:06 +00:00
elebedeva approved these changes 2024-12-25 09:47:36 +00:00
Dismissed
a-savchuk approved these changes 2024-12-25 12:42:28 +00:00
Dismissed
dstepanov-yadro reviewed 2024-12-25 15:26:56 +00:00
pkg/services/object/internal/client/client.go Outdated
@ -73,6 +77,14 @@ func (x *commonPrm) SetXHeaders(hs []string) {
x.xHeaders = hs
}
func (x *commonPrm) getXHeaders() []string {
dstepanov-yadro commented 2024-12-25 15:26:56 +00:00
Member
Copy link

getXHeaders -> xHeaders: https://go.dev/doc/effective_go#Getters

getXHeaders -> xHeaders: https://go.dev/doc/effective_go#Getters
fyrchik commented 2024-12-25 18:09:17 +00:00
Author
Owner
Copy link

it is reserved by the variable name

it is reserved by the variable name
fyrchik commented 2024-12-26 06:49:21 +00:00
Author
Owner
Copy link

renamed to calculateXHeaders -- it is not a simple getter, it does some work.

renamed to `calculateXHeaders` -- it is not a simple getter, it does some work.
dstepanov-yadro marked this conversation as resolved
fyrchik force-pushed xheaders from 683d2ed771 to b772dcfb54 2024-12-26 06:49:08 +00:00 Compare
fyrchik dismissed elebedeva's review 2024-12-26 06:49:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

fyrchik dismissed a-savchuk's review 2024-12-26 06:49:08 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro approved these changes 2024-12-26 07:12:59 +00:00
fyrchik merged commit ca0a33ea0f into master 2024-12-26 09:17:59 +00:00
fyrchik deleted branch xheaders 2024-12-26 09:18:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1580
No description provided.
Delete branch "fyrchik/frostfs-node:xheaders"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?