TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

WIP: [#469] cli: Fix bug with name option for container list command #469

Closed
aarifullin wants to merge 1 commit from aarifullin/frostfs-node:fix/113-list_name_flag into master
pull from: aarifullin/frostfs-node:fix/113-list_name_flag
merge into: TrueCloudLab:master
Conversation 2 Commits 1 Files changed 1 +2 -2
aarifullin commented 2023-06-26 14:21:52 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin changed title from [#XX] cli: Fix bug with name option for container list command to [#469] cli: Fix bug with name option for container list command 2023-06-26 14:22:03 +00:00
aarifullin commented 2023-06-26 14:23:25 +00:00
Author
Member
Copy link

It turned out that for some reason I have not fixed the requested change

It turned out that for some reason I have not fixed the [requested change](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/224#issuecomment-5358)
aarifullin requested review from storage-core-committers 2023-06-26 14:23:31 +00:00
aarifullin requested review from storage-core-developers 2023-06-26 14:23:37 +00:00
anikeev-yadro approved these changes 2023-06-26 14:50:37 +00:00
dstepanov-yadro approved these changes 2023-06-26 15:14:53 +00:00
acid-ant approved these changes 2023-06-26 18:29:08 +00:00
fyrchik reviewed 2023-06-27 07:23:56 +00:00
cmd/frostfs-cli/modules/container/list.go Outdated
@ -71,3 +71,3 @@
cnr := res.Container()
if cnrName := containerSDK.Name(cnr); flagVarListName != "" && cnrName != flagVarListName {
if cnrName := containerSDK.Name(cnr); flagVarListName != "" && !strings.Contains(cnrName, flagVarListName) {
fyrchik commented 2023-06-27 07:23:56 +00:00
Owner
Copy link

Well, we also had #224 (comment)
I think we need to change the help instead.

Well, we also had https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/224#issuecomment-5234 I think we need to change the help instead.
aarifullin commented 2023-06-27 08:53:58 +00:00
Author
Member
Copy link

Fixed. Anyway, it seems that using not whole name but its part is also useful

Fixed. Anyway, it seems that using not whole name but its part is also useful
fyrchik commented 2023-06-28 06:47:27 +00:00
Owner
Copy link

This could be useful, but also makes it impossible to search for the exact name.
The exact name was the original requirement for this task #113

This could be useful, but also makes it impossible to search for the exact name. The exact name was the original requirement for this task https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/113
aarifullin force-pushed fix/113-list_name_flag from 621e11595c to ea5002d20b 2023-06-27 08:53:10 +00:00 Compare
aarifullin requested review from dstepanov-yadro 2023-06-27 08:53:17 +00:00
aarifullin requested review from acid-ant 2023-06-27 08:53:18 +00:00
acid-ant approved these changes 2023-06-27 08:56:17 +00:00
dstepanov-yadro approved these changes 2023-06-28 11:24:57 +00:00
anikeev-yadro approved these changes 2023-06-28 12:04:04 +00:00
aarifullin changed title from [#469] cli: Fix bug with name option for container list command to WIP: [#469] cli: Fix bug with name option for container list command 2023-06-29 09:06:07 +00:00
aarifullin commented 2023-06-30 09:15:19 +00:00
Author
Member
Copy link

Won't be merged

Won't be merged
aarifullin closed this pull request 2023-06-30 09:15:20 +00:00
All checks were successful
ci/woodpecker/pr/pre-commit Pipeline was successful
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
anikeev-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#469
No description provided.
Delete branch "aarifullin/frostfs-node:fix/113-list_name_flag"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?