[#496] Add importas linter #496

Merged
fyrchik merged 1 commits from :feat/linters into master 2023-07-26 21:07:59 +00:00
Collaborator

Add importas liner and standardize the alias of the
import frostfs-sdk-go/object as objectSDK

Add importas liner and standardize the alias of the import frostfs-sdk-go/object as objectSDK
achuprov force-pushed feat/linters from 6010d9c656 to af9380b836 2023-07-06 12:15:37 +00:00 Compare
fyrchik approved these changes 2023-07-06 12:20:45 +00:00
fyrchik left a comment
Owner

Thanks for your contribution!

  1. Make sure commits are "signed" (--signoff option to the commit)
  2. .golangci.yml: prefix to a commit could be useful, like here 33d9ebbe7f

Other than this, LGTM.

Thanks for your contribution! 1. Make sure commits are "signed" (`--signoff` option to the commit) 2. `.golangci.yml: ` prefix to a commit could be useful, like here https://git.frostfs.info/TrueCloudLab/frostfs-node/commit/33d9ebbe7f70c639a7b45373262cda8b3dac00af Other than this, LGTM.
fyrchik requested review from storage-core-committers 2023-07-06 12:21:04 +00:00
fyrchik requested review from storage-core-developers 2023-07-06 12:21:04 +00:00
achuprov force-pushed feat/linters from af9380b836 to 033eaf77e1 2023-07-06 12:40:36 +00:00 Compare
Poster
Collaborator

Thanks for your contribution!

  1. Make sure commits are "signed" (--signoff option to the commit)
  2. .golangci.yml: prefix to a commit could be useful, like here 33d9ebbe7f

Other than this, LGTM.

fixed

> Thanks for your contribution! > 1. Make sure commits are "signed" (`--signoff` option to the commit) > 2. `.golangci.yml: ` prefix to a commit could be useful, like here https://git.frostfs.info/TrueCloudLab/frostfs-node/commit/33d9ebbe7f70c639a7b45373262cda8b3dac00af > > Other than this, LGTM. fixed
achuprov changed title from [#496] Add importas liner to [#496] Add importas linter 2023-07-06 12:41:35 +00:00
acid-ant approved these changes 2023-07-06 13:08:24 +00:00
dstepanov-yadro approved these changes 2023-07-06 13:15:37 +00:00
fyrchik merged commit 033eaf77e1 into master 2023-07-06 15:33:20 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#496
There is no content yet.