TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

Bump go version, update hashicorp/lru to v2 #5

Merged
fyrchik merged 9 commits from update-go into master 2022-12-31 20:04:07 +00:00
Conversation 0 Commits 9 Files changed 26 +131 -160
fyrchik commented 2022-12-30 10:29:46 +00:00 (Migrated from github.com)
Copy link
No description provided.
realloc (Migrated from github.com) reviewed 2022-12-30 10:29:46 +00:00
carpawell (Migrated from github.com) reviewed 2022-12-30 10:29:46 +00:00
acid-ant (Migrated from github.com) reviewed 2022-12-30 10:35:40 +00:00
alexvanin (Migrated from github.com) reviewed 2022-12-30 10:38:55 +00:00
cmd/frostfs-node/cache.go
alexvanin (Migrated from github.com) commented 2022-12-30 10:36:08 +00:00
Copy link

I like how short it gets with generics.

I like how short it gets with generics.
fyrchik (Migrated from github.com) reviewed 2022-12-30 13:34:47 +00:00
cmd/frostfs-node/cache.go
fyrchik (Migrated from github.com) commented 2022-12-30 13:34:47 +00:00
Copy link

Oh, your commment made me think, that we do not need to encode the container ID here, can use cid.ID too. Fixed.

Oh, your commment made me think, that we do not need to encode the container ID here, can use `cid.ID` too. Fixed.
fyrchik (Migrated from github.com) reviewed 2022-12-30 13:35:47 +00:00
cmd/frostfs-node/cache.go
fyrchik (Migrated from github.com) commented 2022-12-30 13:35:47 +00:00
Copy link

The only problem I encountered is that you cannot define a type like type X Type[int, int] and then some methods on top of it.

The only problem I encountered is that you cannot define a type like `type X Type[int, int]` and then some methods on top of it.
alexvanin (Migrated from github.com) approved these changes 2022-12-30 17:26:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
realloc
carpawell
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#5
No description provided.
Delete branch "update-go"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?