TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 114 Pull requests 4 Projects Releases 2 Activity Actions

WIP: Simplify services #6

Closed
fyrchik wants to merge 16 commits from fyrchik/simplify-services into master
pull from: fyrchik/simplify-services
merge into: TrueCloudLab:master
Conversation 3 Commits 16 Files changed 59 +576 -1474
fyrchik commented 2022-12-30 17:04:17 +00:00 (Migrated from github.com)
Copy link

Depends on #5.
TODO testing

Depends on #5. TODO testing
alexvanin (Migrated from github.com) reviewed 2022-12-30 17:04:17 +00:00
acid-ant (Migrated from github.com) reviewed 2023-01-09 08:35:40 +00:00
carpawell (Migrated from github.com) reviewed 2023-01-10 13:01:57 +00:00
carpawell (Migrated from github.com) left a comment
Copy link

Some commits are not formatted, the code is ok to me.

Some commits are not formatted, the code is ok to me.
pkg/services/object/acl/eacl/v2/headers.go Outdated
carpawell (Migrated from github.com) commented 2023-01-10 12:51:25 +00:00
Copy link

i would rename in a separate commit

i would rename in a separate commit
alexvanin commented 2023-01-13 10:05:12 +00:00 (Migrated from github.com)
Copy link

Do we want to run integration tests before merge?

Do we want to run integration tests before merge?
👀 1
fyrchik (Migrated from github.com) reviewed 2023-01-24 10:45:30 +00:00
pkg/services/object/acl/eacl/v2/headers.go Outdated
fyrchik (Migrated from github.com) commented 2023-01-24 10:45:30 +00:00
Copy link

Fixed

Fixed
acid-ant (Migrated from github.com) reviewed 2023-02-21 08:09:59 +00:00
dstepanov-yadro (Migrated from github.com) approved these changes 2023-03-01 13:37:57 +00:00
fyrchik referenced this pull request from a commit 2023-03-09 20:17:05 +00:00
[#6] eacl/v2: Rename `cfg` receiver
fyrchik added 20 commits 2023-03-09 20:17:07 +00:00 
Due to source code relocation from GitHub.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
It will prevent test fails with `-race` flag on components that have
background processes and make some actions on test framework.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
We have lots of small _private_ methods on `execCtx` whose sole purpose
is to just return a struct field.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
It calls a single method from source without any processing.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
All `Service` are accessed by pointer.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
There is no need in a wrapper with many from-`interface{}` conversions.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
There is no need in a wrapper with many from-`interface{}` conversions.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
There is no need in a wrapper with many from-`interface{}` conversions.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
It has only 1 parameter.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
There is no need in a wrapper with many from-`interface{}` conversions.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Make it being used from a single thread.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant approved these changes 2023-03-10 09:09:03 +00:00
carpawell approved these changes 2023-03-10 15:13:56 +00:00
fyrchik referenced this pull request from a commit 2023-03-16 06:58:31 +00:00
[#6] eacl/v2: Rename `cfg` receiver
fyrchik force-pushed fyrchik/simplify-services from e050f40bcb to cab4848d4a 2023-03-16 06:58:32 +00:00 Compare
fyrchik referenced this pull request from a commit 2023-03-21 10:04:23 +00:00
[#6] eacl/v2: Rename `cfg` receiver
fyrchik force-pushed fyrchik/simplify-services from cab4848d4a to 1d3d0b7cc1 2023-03-21 10:04:26 +00:00 Compare
fyrchik changed title from Simplify services to WIP: Simplify services 2023-03-29 13:59:06 +00:00
fyrchik commented 2023-04-05 11:15:02 +00:00
Owner
Copy link

Blocked until we create a support branch for the new release.

Blocked until we create a support branch for the new release.
fyrchik added the
blocked
 label 2023-04-05 11:15:09 +00:00
fyrchik commented 2023-05-15 07:20:02 +00:00
Owner
Copy link

Some of this was fixed in other parts, rebasing will be hard, will create a new PR.

Some of this was fixed in other parts, rebasing will be hard, will create a new PR.
fyrchik closed this pull request 2023-05-15 07:20:03 +00:00
Some checks failed
ci/woodpecker/push/full-pre-commit Pipeline failed
Required
Details
ci/woodpecker/pr/full-pre-commit Pipeline failed
Required
Details
ci/woodpecker/push/pre-commit Pipeline was successful
Required
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
carpawell
alexvanin
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#6
No description provided.
Delete branch "fyrchik/simplify-services"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?