TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

WIP: Simplify services #6

Closed
fyrchik wants to merge 16 commits from fyrchik/simplify-services into master
pull from: fyrchik/simplify-services
merge into: TrueCloudLab:master
Conversation 3 Commits 16 Files Changed 59
fyrchik commented 2022-12-30 17:04:17 +00:00 (Migrated from github.com)

Depends on #5.
TODO testing

Depends on #5. TODO testing
alexvanin (Migrated from github.com) reviewed 2022-12-30 17:04:17 +00:00
acid-ant (Migrated from github.com) reviewed 2023-01-09 08:35:40 +00:00
carpawell (Migrated from github.com) reviewed 2023-01-10 13:01:57 +00:00
carpawell (Migrated from github.com) left a comment

Some commits are not formatted, the code is ok to me.

Some commits are not formatted, the code is ok to me.
pkg/services/object/acl/eacl/v2/headers.go Outdated
carpawell (Migrated from github.com) commented 2023-01-10 12:51:25 +00:00

i would rename in a separate commit

i would rename in a separate commit
alexvanin commented 2023-01-13 10:05:12 +00:00 (Migrated from github.com)

Do we want to run integration tests before merge?

Do we want to run integration tests before merge?
👀 1
fyrchik (Migrated from github.com) reviewed 2023-01-24 10:45:30 +00:00
pkg/services/object/acl/eacl/v2/headers.go Outdated
fyrchik (Migrated from github.com) commented 2023-01-24 10:45:30 +00:00

Fixed

Fixed
acid-ant (Migrated from github.com) reviewed 2023-02-21 08:09:59 +00:00
dstepanov-yadro (Migrated from github.com) approved these changes 2023-03-01 13:37:57 +00:00
fyrchik added 4 commits 2023-03-09 20:17:07 +00:00
20de74a505 Rename package name 
Due to source code relocation from GitHub.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
381e363a8b [#32] node: Always close general components after testing 
It will prevent test fails with `-race` flag on components that have
background processes and make some actions on test framework.

Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
f1f3c80dbf [#32] node: Init write-cache asynchronously 
Signed-off-by: Pavel Karpy <p.karpy@yadro.com>
7486c02bbc [#88] adm: Fix method `nnsResolveKey` 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant approved these changes 2023-03-10 09:09:03 +00:00
carpawell approved these changes 2023-03-10 15:13:56 +00:00
fyrchik force-pushed fyrchik/simplify-services from e050f40bcb to cab4848d4a 2023-03-16 06:58:32 +00:00 Compare
fyrchik force-pushed fyrchik/simplify-services from cab4848d4a to 1d3d0b7cc1 2023-03-21 10:04:26 +00:00 Compare
fyrchik changed title from Simplify services to WIP: Simplify services 2023-03-29 13:59:06 +00:00
fyrchik commented 2023-04-05 11:15:02 +00:00
Owner

Blocked until we create a support branch for the new release.

Blocked until we create a support branch for the new release.
fyrchik added the
blocked
 label 2023-04-05 11:15:09 +00:00
fyrchik commented 2023-05-15 07:20:02 +00:00
Owner

Some of this was fixed in other parts, rebasing will be hard, will create a new PR.

Some of this was fixed in other parts, rebasing will be hard, will create a new PR.
fyrchik closed this pull request 2023-05-15 07:20:03 +00:00
Some checks failed
ci/woodpecker/push/full-pre-commit Pipeline failed
Details
ci/woodpecker/pr/full-pre-commit Pipeline failed
Details
ci/woodpecker/push/pre-commit Pipeline was successful
Required
Details
ci/woodpecker/pr/pre-commit Pipeline was successful
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
carpawell
alexvanin
dstepanov-yadro
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#6
There is no content yet.
Delete Branch "fyrchik/simplify-services"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?