[#540] cli: refactor client parameters usage #540

aarifullin · 2023-07-24T12:25:07Z

aarifullin commented

2023-07-24 12:25:07 +00:00

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

aarifullin changed title from ~~[#XX] frostfs-cli: refactor client parameters usage~~ to WIP: [#XX] frostfs-cli: refactor client parameters usage

2023-07-24 12:25:14 +00:00

aarifullin changed title from ~~WIP: [#XX] frostfs-cli: refactor client parameters usage~~ to WIP: [#540] frostfs-cli: refactor client parameters usage

2023-07-31 07:44:41 +00:00

aarifullin force-pushed feature/121-client/container_put from bd89519d2b to 42ee81e1fc

2023-08-01 10:29:37 +00:00

Compare

aarifullin force-pushed feature/121-client/container_put from 42ee81e1fc to 098122ce47

2023-08-01 10:35:38 +00:00

Compare

aarifullin changed title from ~~WIP: [#540] frostfs-cli: refactor client parameters usage~~ to [#540] frostfs-cli: refactor client parameters usage

2023-08-01 10:35:45 +00:00

aarifullin requested review from storage-core-committers 2023-08-01 10:35:56 +00:00

aarifullin requested review from storage-core-developers 2023-08-01 10:35:57 +00:00

acid-ant approved these changes 2023-08-01 10:42:23 +00:00

aarifullin reviewed 2023-08-01 11:29:35 +00:00

cmd/frostfs-cli/modules/container/create.go Outdated

					
				@ -108,1 +106,4 @@

								Session:   tok,

							},

						}

						putPrm.SetClient(cli)

aarifullin commented

2023-08-01 11:29:35 +00:00

internalclient.PutContainerPrm is NOT the part of SDK (but node's). So, that's why SetClient is still here

`internalclient.PutContainerPrm` is NOT the part of SDK (but node's). So, that's why `SetClient` is still here

aarifullin changed title from ~~[#540] frostfs-cli: refactor client parameters usage~~ to [#540] cli: refactor client parameters usage

2023-08-01 12:39:43 +00:00

aarifullin force-pushed feature/121-client/container_put from 098122ce47 to a4444a71be

2023-08-01 12:40:50 +00:00

Compare

aarifullin requested review from acid-ant 2023-08-01 13:03:47 +00:00

fyrchik approved these changes 2023-08-02 09:44:44 +00:00

fyrchik merged commit 1b7b54ba89 into master

2023-08-02 09:44:53 +00:00

fyrchik referenced this pull request from a commit

2023-08-02 09:44:55 +00:00

[#540] cli: refactor client parameters usage

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#540