[#18] Add badgerstore substorage implementation #556

Closed

ale64bit wants to merge 1 commits from ale64bit/frostfs-node:feature/flat-blobstore-test into master

ale64bit commented

2023-08-02 08:36:09 +00:00

Collaborator

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit added the

label 2023-08-02 08:36:09 +00:00

ale64bit requested review from storage-core-committers 2023-08-02 08:41:45 +00:00

ale64bit requested review from storage-core-developers 2023-08-02 08:41:45 +00:00

dstepanov-yadro reviewed 2023-08-02 15:38:39 +00:00

pkg/local_object_storage/blobstor/badgerstore/badgerstore.go Outdated

													
				@ -0,0 +132,4 @@

					addrKey := addressKey(req.Address)

					err := s.db.Update(func(tx *badger.Txn) error {

						if _, err := tx.Get(addrKey[:]); err != nil {

dstepanov-yadro commented

2023-08-02 15:38:39 +00:00

Collaborator

Please explain why Get first and only then Delete?

Please explain why Get first and only then Delete?

ale64bit commented

2023-08-03 06:33:00 +00:00

Poster

Collaborator

Our Delete must return apistatus.ObjectNotFound. But badger doesn't return badger.ErrKeyNotFound when deleting, so I call Get first to check that.

Our `Delete` must return `apistatus.ObjectNotFound`. But badger doesn't return `badger.ErrKeyNotFound` when deleting, so I call `Get` first to check that.

dstepanov-yadro approved these changes 2023-08-02 15:41:30 +00:00

aarifullin approved these changes 2023-08-14 15:16:14 +00:00

ale64bit force-pushed feature/flat-blobstore-test from 8600e65f59 to 440cf85d62

2023-09-01 07:35:54 +00:00

Compare

fyrchik closed this pull request

2024-03-29 20:46:59 +00:00

DCO action / DCO (pull_request) Successful in 2m8s

Details

Vulncheck / Vulncheck (pull_request) Successful in 3m59s

Details

Build / Build Components (1.21) (pull_request) Successful in 4m48s

Details

Build / Build Components (1.20) (pull_request) Successful in 4m56s

Details

Tests and linters / Staticcheck (pull_request) Successful in 5m50s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 7m20s

Details

Tests and linters / Lint (pull_request) Successful in 7m29s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 7m37s

Details

Tests and linters / Tests with -race (pull_request) Successful in 9m48s

Details

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

good first issue

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#556

There is no content yet.