TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

[#18] Add badgerstore substorage implementation #556

Closed
ale64bit wants to merge 1 commit from ale64bit/frostfs-node:feature/flat-blobstore-test into master
pull from: ale64bit/frostfs-node:feature/flat-blobstore-test
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 10 +607 -5
ale64bit commented 2023-08-02 08:36:09 +00:00
Member
Copy link

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
ale64bit added the
discussion
 label 2023-08-02 08:36:09 +00:00
ale64bit requested review from storage-core-committers 2023-08-02 08:41:45 +00:00
ale64bit requested review from storage-core-developers 2023-08-02 08:41:45 +00:00
dstepanov-yadro reviewed 2023-08-02 15:38:39 +00:00
pkg/local_object_storage/blobstor/badgerstore/badgerstore.go Outdated
@ -0,0 +132,4 @@
addrKey := addressKey(req.Address)
err := s.db.Update(func(tx *badger.Txn) error {
if _, err := tx.Get(addrKey[:]); err != nil {
dstepanov-yadro commented 2023-08-02 15:38:39 +00:00
Member
Copy link

Please explain why Get first and only then Delete?

Please explain why Get first and only then Delete?
ale64bit commented 2023-08-03 06:33:00 +00:00
Author
Member
Copy link

Our Delete must return apistatus.ObjectNotFound. But badger doesn't return badger.ErrKeyNotFound when deleting, so I call Get first to check that.

Our `Delete` must return `apistatus.ObjectNotFound`. But badger doesn't return `badger.ErrKeyNotFound` when deleting, so I call `Get` first to check that.
dstepanov-yadro approved these changes 2023-08-02 15:41:30 +00:00
aarifullin approved these changes 2023-08-14 15:16:14 +00:00
ale64bit force-pushed feature/flat-blobstore-test from 8600e65f59 to 440cf85d62 2023-09-01 07:35:54 +00:00 Compare
fyrchik closed this pull request 2024-03-29 20:46:59 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 2m8s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m59s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 4m48s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 4m56s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m50s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m20s
Required
Details
Tests and linters / Lint (pull_request) Successful in 7m29s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 7m37s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m48s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#556
No description provided.
Delete branch "ale64bit/frostfs-node:feature/flat-blobstore-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?