Hold mode lock when changing mode #603
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#603
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "ale64bit/frostfs-node:fix/598-wc-test-panic"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -59,2 +59,4 @@
check(t, mb, bs, objects)
require.NoError(t, wc.Close())
We already have it in
newCache
viat.Cleanup
, why do we need it here?true, removed it.
dc19d54181
to745c9be4c9
Hold mode lock when changing mode and close writecache after flush teststo Hold mode lock when changing modeWe have lost mtx.Lock/mtx.Unlock here: #377/files
Previously, taking a lock was more granular. Can you check if we can make this lock more granular?
In which way was was it more granular? I put it back in the same place it was before.
Sorry, you're right, my mistake