TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 91 Pull requests 3 Projects Releases 1 Activity Actions

Hold mode lock when changing mode #603

Merged
fyrchik merged 1 commit from ale64bit/frostfs-node:fix/598-wc-test-panic into master 2023-08-14 07:12:29 +00:00
Conversation 3 Commits 1 Files changed 2 +6
ale64bit commented 2023-08-11 13:45:10 +00:00
Member
Copy link
No description provided.
ale64bit added 1 commit 2023-08-11 13:45:12 +00:00
[#598] Hold mode mutex when setting mode
Some checks failed
DCO action / DCO (pull_request) Successful in 4m38s
Details
Vulncheck / Vulncheck (pull_request) Successful in 4m11s
Details
Build / Build Components (1.21) (pull_request) Successful in 5m14s
Details
Tests and linters / Lint (pull_request) Successful in 5m45s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m7s
Details
Build / Build Components (1.20) (pull_request) Successful in 6m55s
Details
Tests and linters / Tests (1.21) (pull_request) Failing after 13m29s
Details
Tests and linters / Tests with -race (pull_request) Failing after 13m52s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 15m18s
Details
745c9be4c9 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
ale64bit requested review from storage-core-committers 2023-08-11 13:45:24 +00:00
ale64bit requested review from storage-core-developers 2023-08-11 13:45:28 +00:00
fyrchik reviewed 2023-08-11 13:48:07 +00:00
pkg/local_object_storage/writecache/writecachetest/flush.go Outdated
@ -59,2 +59,4 @@
check(t, mb, bs, objects)
require.NoError(t, wc.Close())
fyrchik commented 2023-08-11 13:48:07 +00:00
Owner
Copy link

We already have it in newCache via t.Cleanup, why do we need it here?

We already have it in `newCache` via `t.Cleanup`, why do we need it here?
ale64bit commented 2023-08-11 13:51:12 +00:00
Author
Member
Copy link

true, removed it.

true, removed it.
fyrchik reviewed 2023-08-11 13:48:10 +00:00
ale64bit force-pushed fix/598-wc-test-panic from dc19d54181 to 745c9be4c9 2023-08-11 13:50:57 +00:00 Compare
ale64bit changed title from Hold mode lock when changing mode and close writecache after flush tests to Hold mode lock when changing mode 2023-08-11 13:51:36 +00:00
dstepanov-yadro commented 2023-08-11 15:22:11 +00:00
Member
Copy link

We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392
Previously, taking a lock was more granular. Can you check if we can make this lock more granular?

We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392 Previously, taking a lock was more granular. Can you check if we can make this lock more granular?
ale64bit commented 2023-08-14 06:44:00 +00:00
Author
Member
Copy link

We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392
Previously, taking a lock was more granular. Can you check if we can make this lock more granular?

In which way was was it more granular? I put it back in the same place it was before.

> We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392 > Previously, taking a lock was more granular. Can you check if we can make this lock more granular? > In which way was was it more granular? I put it back in the same place it was before.
dstepanov-yadro commented 2023-08-14 06:47:51 +00:00
Member
Copy link

We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392
Previously, taking a lock was more granular. Can you check if we can make this lock more granular?

In which way was was it more granular? I put it back in the same place it was before.

Sorry, you're right, my mistake

> > We have lost mtx.Lock/mtx.Unlock here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/377/files#diff-8513d44b0cfcfbc8e90a26903e4c57b1f19d4392 > > Previously, taking a lock was more granular. Can you check if we can make this lock more granular? > > > > In which way was was it more granular? I put it back in the same place it was before. Sorry, you're right, my mistake
👍 1
dstepanov-yadro approved these changes 2023-08-14 06:47:57 +00:00
fyrchik approved these changes 2023-08-14 07:12:23 +00:00
fyrchik merged commit 376f03a445 into master 2023-08-14 07:12:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#603
No description provided.
Delete branch "ale64bit/frostfs-node:fix/598-wc-test-panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?