TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 5 Projects Releases 1 Activity Actions

shard: Fix data race in metrics tests #637

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:fix-test into master 2023-08-23 10:26:13 +00:00
Conversation 0 Commits 1 Files changed 1 +21 -3
fyrchik commented 2023-08-23 07:45:03 +00:00
Owner
Copy link

Close #633.

Protect test metric store fields with a mutex. Probably, not every field
should be protected, but better safe than sorry.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Close #633. Protect test metric store fields with a mutex. Probably, not every field should be protected, but [better safe than sorry](https://www.youtube.com/watch?v=djV11Xbc914). Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2023-08-23 07:45:06 +00:00
[#xx] shard: Fix data race in metrics tests
All checks were successful
DCO action / DCO (pull_request) Successful in 1m44s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m54s
Details
Build / Build Components (1.20) (pull_request) Successful in 3m35s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m45s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 5m18s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 5m34s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m0s
Details
Build / Build Components (1.21) (pull_request) Successful in 12m50s
Details
Tests and linters / Lint (pull_request) Successful in 14m13s
Details
53340435b1 
Protect test metric store fields with a mutex. Probably, not every field
should be protected, but better safe than sorry.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added a new dependency 2023-08-23 07:45:50 +00:00
#633 TestCounters is flaky
fyrchik removed a dependency 2023-08-23 07:46:01 +00:00
#633 TestCounters is flaky
fyrchik requested review from storage-core-committers 2023-08-23 07:46:11 +00:00
fyrchik requested review from storage-core-developers 2023-08-23 07:46:12 +00:00
acid-ant approved these changes 2023-08-23 07:52:42 +00:00
fyrchik merged commit 82cc453be9 into master 2023-08-23 10:26:13 +00:00
fyrchik deleted branch fix-test 2023-08-23 10:26:14 +00:00
fyrchik referenced this pull request from a commit 2023-08-25 10:10:30 +00:00
[#637] shard/test: Fix data race
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#637
No description provided.
Delete branch "fyrchik/frostfs-node:fix-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?