ir: Add health status #87

Merged
fyrchik merged 2 commits from acid-ant/frostfs-node:feature/50-hc-for-ir into master 2023-03-13 11:24:43 +00:00
Member

Close #50

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #50 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from fyrchik 2023-03-07 11:21:39 +00:00
acid-ant requested review from carpawell 2023-03-07 11:21:39 +00:00
acid-ant requested review from ale64bit 2023-03-07 11:21:39 +00:00
acid-ant requested review from dstepanov-yadro 2023-03-07 11:21:47 +00:00
acid-ant changed title from [#50] ir: Add health status to ir: Add health status 2023-03-07 11:56:19 +00:00
dstepanov-yadro approved these changes 2023-03-07 14:00:40 +00:00
fyrchik reviewed 2023-03-09 08:33:56 +00:00
@ -926,3 +926,3 @@
})
if cfg.GetString("metrics.address") != "" {
if cfg.GetString("prometheus.address") != "" {
Owner

Worth a separate commit.

Worth a separate commit.
Author
Member

Agree, moved in separate commit.

Agree, moved in separate commit.
fyrchik marked this conversation as resolved
@ -168,2 +168,4 @@
func (s *Server) setHealthStatus(hs control.HealthStatus) {
s.healthStatus.Store(hs)
if s.metrics != nil {
s.metrics.SetHealth(int32(hs))
Owner

Does the number means the same for other services? Like 0 == HEALTHY?

Does the number means the same for other services? Like 0 == HEALTHY?
Author
Member

We have two enums for HealthStatus - one in control and one in ir. But they have the same numbers for statuses. Can we move HealthStatus in common proto file, one for both packages?

We have two enums for HealthStatus - one in `control` and one in `ir`. But they have the same numbers for statuses. Can we move HealthStatus in `common` proto file, one for both packages?
acid-ant force-pushed feature/50-hc-for-ir from b1f2bec8d7 to b8c3b5a74d 2023-03-10 16:10:37 +00:00 Compare
acid-ant force-pushed feature/50-hc-for-ir from b8c3b5a74d to 72145c2a08 2023-03-13 06:21:48 +00:00 Compare
fyrchik approved these changes 2023-03-13 11:24:37 +00:00
fyrchik merged commit 5ae4446280 into master 2023-03-13 11:24:43 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#87
No description provided.