ir: Add health status #87

acid-ant · 2023-03-07T11:20:43Z

acid-ant commented

2023-03-07 11:20:43 +00:00

Close #50

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #50 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant requested review from fyrchik 2023-03-07 11:21:39 +00:00

acid-ant requested review from carpawell 2023-03-07 11:21:39 +00:00

acid-ant requested review from ale64bit 2023-03-07 11:21:39 +00:00

acid-ant requested review from dstepanov-yadro 2023-03-07 11:21:47 +00:00

acid-ant changed title from ~~[#50] ir: Add health status~~ to ir: Add health status

2023-03-07 11:56:19 +00:00

dstepanov-yadro approved these changes 2023-03-07 14:00:40 +00:00

fyrchik reviewed 2023-03-09 08:33:56 +00:00

pkg/innerring/innerring.go Outdated

					
				@ -926,3 +926,3 @@

					})

					if cfg.GetString("metrics.address") != "" {

					if cfg.GetString("prometheus.address") != "" {

fyrchik commented

2023-03-09 08:33:32 +00:00

Worth a separate commit.

👍 1

acid-ant commented

2023-03-13 06:22:56 +00:00

Agree, moved in separate commit.

fyrchik marked this conversation as resolved

pkg/innerring/state.go Outdated

					
				@ -168,2 +168,4 @@

				func (s *Server) setHealthStatus(hs control.HealthStatus) {

					s.healthStatus.Store(hs)

					if s.metrics != nil {

						s.metrics.SetHealth(int32(hs))

fyrchik commented

2023-03-09 08:33:52 +00:00

Does the number means the same for other services? Like 0 == HEALTHY?

acid-ant commented

2023-03-10 17:01:33 +00:00

We have two enums for HealthStatus - one in control and one in ir. But they have the same numbers for statuses. Can we move HealthStatus in common proto file, one for both packages?

We have two enums for HealthStatus - one in `control` and one in `ir`. But they have the same numbers for statuses. Can we move HealthStatus in `common` proto file, one for both packages?