TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 4 Projects Releases 1 Activity Actions

node: Start metrics and pprof as soon as possible #882

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/metrics_start_order into master 2023-12-21 15:09:55 +00:00
Conversation 0 Commits 1 Files changed 2 +9 -21
dstepanov-yadro commented 2023-12-20 13:23:45 +00:00
Member
Copy link

Closes #873

Closes #873
dstepanov-yadro added 1 commit 2023-12-20 13:23:48 +00:00
[#873] node: Start metrics and pprof as soon as possible
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 3m24s
Details
DCO action / DCO (pull_request) Successful in 3m49s
Details
Build / Build Components (1.21) (pull_request) Successful in 4m15s
Details
Build / Build Components (1.20) (pull_request) Successful in 4m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m30s
Details
Tests and linters / Lint (pull_request) Successful in 6m29s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 10m21s
Details
Tests and linters / Tests with -race (pull_request) Successful in 10m21s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 10m35s
Details
4bf241109b 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
acid-ant approved these changes 2023-12-20 13:43:57 +00:00
elebedeva approved these changes 2023-12-20 16:28:04 +00:00
fyrchik reviewed 2023-12-21 12:27:12 +00:00
cmd/frostfs-node/httpcomponent.go
@ -39,0 +43,4 @@
c.log.Info(logs.FrostFSNodeStartListeningEndpoint,
zap.String("service", cmp.name),
zap.String("endpoint", cmp.address))
fatalOnErr(srv.Serve())
fyrchik commented 2023-12-21 12:26:20 +00:00
Owner
Copy link

Not the case here (everything is on localhost), but what about your recent optimization regarding rebinging to a not-yet-available IP, will it work?

Not the case here (everything is on localhost), but what about your recent optimization regarding rebinging to a not-yet-available IP, will it work?
dstepanov-yadro commented 2023-12-21 13:01:58 +00:00
Author
Member
Copy link

Now not

Now not
fyrchik commented 2023-12-21 15:09:45 +00:00
Owner
Copy link

Ok, our current configuration everywhere uses localhost, so #836 is still useful.

Ok, our current configuration everywhere uses localhost, so #836 is still useful.
fyrchik approved these changes 2023-12-21 12:27:47 +00:00
fyrchik merged commit 825f65f79e into master 2023-12-21 15:09:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
elebedeva
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#882
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/metrics_start_order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?