node: Start metrics and pprof as soon as possible #882

dstepanov-yadro · 2023-12-20T13:23:45Z

dstepanov-yadro commented

2023-12-20 13:23:45 +00:00

Closes #873

dstepanov-yadro added 1 commit 2023-12-20 13:23:48 +00:00

Vulncheck / Vulncheck (pull_request) Successful in 3m24s Details

DCO action / DCO (pull_request) Successful in 3m49s Details

Build / Build Components (1.21) (pull_request) Successful in 4m15s Details

Build / Build Components (1.20) (pull_request) Successful in 4m32s Details

Tests and linters / Staticcheck (pull_request) Successful in 5m30s Details

Tests and linters / Lint (pull_request) Successful in 6m29s Details

Tests and linters / Tests (1.20) (pull_request) Successful in 10m21s Details

Tests and linters / Tests with -race (pull_request) Successful in 10m21s Details

Tests and linters / Tests (1.21) (pull_request) Successful in 10m35s Details

4bf241109b [#873 ] node: Start metrics and pprof as soon as possible

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

acid-ant approved these changes 2023-12-20 13:43:57 +00:00

elebedeva approved these changes 2023-12-20 16:28:04 +00:00

fyrchik reviewed 2023-12-21 12:27:12 +00:00

cmd/frostfs-node/httpcomponent.go

													
				@ -39,0 +43,4 @@

						c.log.Info(logs.FrostFSNodeStartListeningEndpoint,

							zap.String("service", cmp.name),

							zap.String("endpoint", cmp.address))

						fatalOnErr(srv.Serve())

fyrchik commented

2023-12-21 12:26:20 +00:00

Not the case here (everything is on localhost), but what about your recent optimization regarding rebinging to a not-yet-available IP, will it work?

dstepanov-yadro commented

2023-12-21 13:01:58 +00:00

Poster

Now not

fyrchik commented

2023-12-21 15:09:45 +00:00

Ok, our current configuration everywhere uses localhost, so #836 is still useful.

fyrchik approved these changes 2023-12-21 12:27:47 +00:00

fyrchik merged commit 825f65f79e into master

2023-12-21 15:09:55 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#882