TrueCloudLab/frostfs-node

Fork 27

DeletePolicy returns Internal error code if the policy not found #898

New issue

Closed

opened 2024-01-10 12:09:18 +00:00 by ironbee · 2 comments

ironbee commented

2024-01-10 12:09:18 +00:00

Contributor

When DeletePolicy is called upon non-existing policy, it responds with Internal code. However, the NotFound code seems to be more appropriate for such case.

Sample of the error message:

remove chain policy from node: exec raw: rpc error: code = Internal desc = chain name not found

When DeletePolicy is called upon non-existing policy, it responds with Internal code. However, the NotFound code seems to be more appropriate for such case. Sample of the error message: ``` remove chain policy from node: exec raw: rpc error: code = Internal desc = chain name not found ```

ironbee added the

bug

triage

labels 2024-01-10 12:09:18 +00:00

fyrchik added

frostfs-node

and removed

triage

labels 2024-01-10 12:31:41 +00:00

fyrchik added this to the v0.38.0 milestone 2024-01-10 12:31:44 +00:00

aarifullin self-assigned this 2024-01-10 12:42:27 +00:00

aarifullin referenced this issue from a commit

2024-01-11 08:53:19 +00:00

[#898] ape: Fix bug with creating type bucket in chainbase

aarifullin referenced this issue from a commit

2024-01-11 08:53:19 +00:00

[#898] control: Fix codes for returning APE errors

fyrchik referenced this issue from a commit

2024-01-11 12:31:33 +00:00

[#898] ape: Fix bug with creating type bucket in chainbase

fyrchik referenced this issue from a commit

2024-01-11 12:31:33 +00:00

[#898] control: Fix codes for returning APE errors

aarifullin commented

2024-01-11 14:24:22 +00:00

Member

Fixed with #901

Fixed with [#901](https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/901)

aarifullin closed this issue

2024-01-11 14:24:22 +00:00

aarifullin commented

2024-02-26 08:35:35 +00:00

Member

Deleting non-existing target (not non-existing chain-id) leads to rule has not been removed:


service@aleksandrmaksimov-node1[alone_datacenter]:~$ frostfs-cli --endpoint localhost:8091 -w test.json control remove-rule --target-type container --target-name 6VJRRegia1igEU9vCrMKMDkgmabcuVfVe6eEp1yn2BDD --chain-id chainRestrictObject
Enter password >
Rule has not been removed.

This should be also fixed

Deleting non-existing target (not non-existing chain-id) leads to `rule has not been removed`: ```bash service@aleksandrmaksimov-node1[alone_datacenter]:~$ frostfs-cli --endpoint localhost:8091 -w test.json control remove-rule --target-type container --target-name 6VJRRegia1igEU9vCrMKMDkgmabcuVfVe6eEp1yn2BDD --chain-id chainRestrictObject Enter password > Rule has not been removed. ``` This should be also fixed

aarifullin reopened this issue

2024-02-26 08:35:37 +00:00

aarifullin referenced this issue from a pull request that will close it,

2024-02-26 08:58:21 +00:00

ape: Make RemoveChainLocalOverride set correct removed flag #1006

fyrchik closed this issue

2024-02-28 19:07:11 +00:00

fyrchik referenced this issue from a commit

2024-02-28 19:07:12 +00:00

[#898] control: Remove removed flag from RemoveChainLocalOverrideResponse