TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

ape: Make RemoveChainLocalOverride set correct removed flag #1006

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/898_removed-true into master 2024-02-28 19:07:10 +00:00
Conversation 0 Commits 1 Files changed 5 +3 -14
aarifullin commented 2024-02-26 08:58:20 +00:00
Member
Copy link
  • If LocalStorage error status is NotFound, then set removed flag to true anyway.

Close #898

* If LocalStorage error status is NotFound, then set removed flag to true anyway. Close #898
aarifullin requested review from storage-core-committers 2024-02-26 08:58:34 +00:00
aarifullin requested review from storage-core-developers 2024-02-26 08:58:44 +00:00
acid-ant approved these changes 2024-02-26 09:23:18 +00:00
fyrchik reviewed 2024-02-26 12:17:09 +00:00
pkg/services/control/server/policy_engine.go Outdated
@ -164,3 +164,3 @@
code := getCodeByLocalStorageErr(err)
if code == codes.NotFound {
removed = false
removed = true
fyrchik commented 2024-02-26 12:17:09 +00:00
Owner
Copy link

So what do we need remove flag for if it is always true?

So what do we need `remove` flag for if it is always true?
aarifullin commented 2024-02-26 12:54:09 +00:00
Author
Member
Copy link

You're right. I have removed remove flag. But removed in the response body is left as a first implementation flavor, because we agreed about to return success even a chain is not found after control API had introduced Remove method

You're right. I have removed `remove` flag. But `removed` in the response body is left as a first implementation *flavor*, because we agreed about to return *success* even a chain is not found after control API had introduced `Remove` method
fyrchik commented 2024-02-26 16:34:14 +00:00
Owner
Copy link

I don't understand, what is the reason to have field in the body which is always true?
Is someone already dependent on it?

I don't understand, what is the reason to have field in the body which is always true? Is someone already dependent on it?
aarifullin force-pushed fix/898_removed-true from 7d3bed0821 to 63a8ef63d4 2024-02-26 12:45:14 +00:00 Compare
fyrchik reviewed 2024-02-26 12:59:14 +00:00
pkg/services/control/server/policy_engine.go Outdated
@ -171,3 +168,3 @@
resp := &control.RemoveChainLocalOverrideResponse{
Body: &control.RemoveChainLocalOverrideResponse_Body{
Removed: removed,
Removed: true,
fyrchik commented 2024-02-26 12:59:14 +00:00
Owner
Copy link

Do we need this in control service at all?

Do we need this in control service at all?
aarifullin commented 2024-02-27 09:31:10 +00:00
Author
Member
Copy link

Alright. It seems Removed is really confusing flag. I have removed it proto, regenerated protobufs and fix control API and cli!

Alright. It seems `Removed` is really confusing flag. I have removed it `proto`, regenerated protobufs and fix control API and cli!
aarifullin force-pushed fix/898_removed-true from 63a8ef63d4 to b19b268baa 2024-02-27 09:29:47 +00:00 Compare
aarifullin force-pushed fix/898_removed-true from b19b268baa to 470862baab 2024-02-27 09:30:06 +00:00 Compare
aarifullin requested review from acid-ant 2024-02-27 09:31:26 +00:00
acid-ant approved these changes 2024-02-27 10:15:55 +00:00
fyrchik approved these changes 2024-02-28 19:07:00 +00:00
fyrchik merged commit 93bf9acbc2 into master 2024-02-28 19:07:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1006
No description provided.
Delete branch "aarifullin/frostfs-node:fix/898_removed-true"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?