Fix get range hash #906

dstepanov-yadro · 2024-01-12T07:19:38Z

dstepanov-yadro commented

2024-01-12 07:19:38 +00:00

Relates #891

To reproduce on 4 node cluster:

create container with REP 1 IN X CBF 1 SELECT 1 FROM * AS X and put object
try to get range hash (frostfs-cli object hash --range ...) from different nodes
The request will be executed successfully on only one node (container node). Other requests will fail with access denied error, because get range hash performs get request signed with node's key.

Now node redirects get range hash request to container node, so all subsequent requests will pass.

Relates #891 To reproduce on 4 node cluster: 1. create container with `REP 1 IN X CBF 1 SELECT 1 FROM * AS X` and put object 2. try to get range hash (`frostfs-cli object hash --range ...`) from different nodes The request will be executed successfully on only one node (container node). Other requests will fail with access denied error, because get range hash performs get request signed with node's key. Now node redirects get range hash request to container node, so all subsequent requests will pass.

dstepanov-yadro requested review from storage-core-committers 2024-01-12 07:32:54 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-01-12 07:32:55 +00:00

fyrchik approved these changes 2024-01-12 08:06:30 +00:00

internal/logs/logs.go Outdated

					
				@ -567,4 +567,8 @@ const (

					EngineInterruptProcessingZeroSizeContainers                             = "interrupt processing zero-size containers"

					EngineInterruptProcessingZeroCountContainers                            = "interrupt processing zero-count containers"

					EngineFailedToGetContainerCounters                                      = "failed to get container counters"

					GetSvcV2FailedToParseNodeEndpoints                                      = "failed to parse node endpoints"

fyrchik commented

2024-01-12 07:36:30 +00:00

Seems like a generic error, don't we have it in other redirect places?

dstepanov-yadro commented

2024-01-12 09:02:54 +00:00

Nope, traverser ignores it.

fyrchik marked this conversation as resolved

pkg/services/object/get/v2/get_range_hash.go Outdated

					
				@ -0,0 +48,4 @@

					address        oid.Address

				}

				func (s *Service) needToForwardGetRangeHashRequest(req *objectV2.GetRangeHashRequest) (getRangeForwardParams, error) {

fyrchik commented

2024-01-12 07:44:56 +00:00

Is it copied from some other forwarding place? Does it make sense to reuse the code here?

👍 1

dstepanov-yadro commented

2024-01-12 09:00:40 +00:00

Nope

fyrchik marked this conversation as resolved

pkg/services/object/get/v2/get_range_hash.go Outdated

					
				@ -0,0 +88,4 @@

					if err != nil {

						return result, fmt.Errorf("(%T) could not build object placement: %w", s, err)

					}

					result.containerNodes = distinctBy(placement.FlattenNodes(nodesVector), func(n netmapSDK.NodeInfo) string { return hex.EncodeToString(n.PublicKey()) })