TrueCloudLab/frostfs-node

Fork 27

Check response status in range hash forwarder #1134

Merged

fyrchik merged 1 commit from fyrchik/frostfs-node:fix-get-range-status into master

2024-09-04 19:51:08 +00:00

fyrchik commented

2024-05-15 09:05:04 +00:00

Owner

Fixes #1083
Refs #891, #906

Fixes #1083 Refs #891, #906

fyrchik added 2 commits 2024-05-15 09:05:07 +00:00

[#1083 ] objsvc/v2: Properly check response status after forwarding 300654b045

Previously we had cryptic error:
```
debug   get/remote.go:38        remote call failed      {"component": "Object.Get service", "request": "HEAD", "address": "9sTxoVrhJ7WBtXQfK2NJ7zDV5yCF7BPLKK1XTxYPdGsP/BbHV4KZZ8y2BPqAT5kyjdHRLkfbtY2xf5uYoMVqxACn1", "raw": false, "local": false, "with session": false, "with bearer": false, "error": "unexpected header type <nil>"}
```
Now we have and expected error:
```
debug   get/remote.go:38        remote call failed      {"component": "Object.Get service", "request": "HEAD", "address": "D2rqaMG4D2VHdv3HKky8UYSYmwQFH2v9oXXqtyRZPTMy/BbHV4KZZ8y2BPqAT5kyjdHRLkfbtY2xf5uYoMVqxACn1", "raw": false, "local": false, "with session": false, "with bearer": false, "error": "status: code = 2049 message = object not found"}
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

[#1083 ] objsvc/v2: Unify response verification after forwarding 0924b62a95

1. Use the same routine for HEAD/GET_RANGE methods.
2. Make error message similar.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-05-15 09:05:40 +00:00

fyrchik requested review from storage-core-developers 2024-05-15 09:05:49 +00:00

acid-ant approved these changes 2024-05-15 09:37:32 +00:00

dstepanov-yadro approved these changes 2024-05-15 09:51:51 +00:00

aarifullin approved these changes 2024-05-15 10:03:01 +00:00

fyrchik force-pushed fix-get-range-status from 4fb4dd73da to b3eaa8a9bc

2024-05-15 10:08:50 +00:00

Compare

fyrchik merged commit b3eaa8a9bc into master

2024-05-15 11:02:07 +00:00

fyrchik deleted branch fix-get-range-status

2024-05-15 11:02:28 +00:00

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1134

No description provided.