TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Wrong shardID in write_cache metrics #948

New Issue
Closed
opened 2024-01-31 15:05:20 +00:00 by anikeev-yadro · 3 comments
anikeev-yadro commented 2024-01-31 15:05:20 +00:00

Expected Behavior

ShardID in write_cache metrics should be actual.

Current Behavior

Wrong shardID in write_cache metrics

Steps to Reproduce (for bugs)

  1. Load objects to system
  2. Get shards list
root@acidrock-node3:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards list |grep Shard
Shard 2b2YD4bD9PRxFxyzHAhts9:
Shard 36GWtTpmrysnEbVg6W9DeY:
Shard 57tq8ASxdQfz7U2mbPiGSS:
Shard 5ucn5La3mgb5X56CRdD2vi:
Shard 7Bp81xgzjXjb9aZaye1NaY:
Shard 9iEZkF2baYX3vYXhZy8RAn:
Shard ALFPBFPL5DJGH3CdawtEJ6:
Shard CkTWM7dZHX8VJ27zytDZ7s:
Shard DKWL6gS9Rud2weL677pE7B:
Shard Jm2CDQFxLEx5Crx5dLgVLQ:
Shard SF3GFXQuiSFjhLby2jw3x5:
Shard WBqmYHpikU885KR7bTYWmx:
  1. Get write_cache metrics
service@acidrock-node3:~$ curl -s localhost:6672 | grep frostfs_node_writecache_actual_objects_total
# HELP frostfs_node_writecache_actual_objects_total Actual objects count in writecache
# TYPE frostfs_node_writecache_actual_objects_total gauge
frostfs_node_writecache_actual_objects_total{shard_id="8iGfU7isckfx955JymebgF",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="8iGfU7isckfx955JymebgF",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="9keJuCxVGeT6RRKhL64tPf",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="9keJuCxVGeT6RRKhL64tPf",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="AoUGTA2St7hnSgsWR2piDb",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="AoUGTA2St7hnSgsWR2piDb",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="CbRYuBY6fQQBfCz8nXa3P8",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="CbRYuBY6fQQBfCz8nXa3P8",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="FDg785WYwBoW8cVEUMz8dh",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="FDg785WYwBoW8cVEUMz8dh",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="MNdpKFc27B19QMJ5tNek2t",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="MNdpKFc27B19QMJ5tNek2t",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="NFPPgeEwfRMFwzfJLHF92u",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="NFPPgeEwfRMFwzfJLHF92u",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="RgBH9fQVGCiHba2ayrFVfh",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="RgBH9fQVGCiHba2ayrFVfh",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="S92ymKDcqHyjv1EB9UT7Pq",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="S92ymKDcqHyjv1EB9UT7Pq",storage="fstree"} 1
frostfs_node_writecache_actual_objects_total{shard_id="VFZStpQoxrrk4BmeCX3bo5",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="VFZStpQoxrrk4BmeCX3bo5",storage="fstree"} 0
frostfs_node_writecache_actual_objects_total{shard_id="WJ2bwYKp1fE3ni4SVNMUkn",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="WJ2bwYKp1fE3ni4SVNMUkn",storage="fstree"} 1
frostfs_node_writecache_actual_objects_total{shard_id="WpciPW28k4dzDBYMwehDgg",storage="db"} 0
frostfs_node_writecache_actual_objects_total{shard_id="WpciPW28k4dzDBYMwehDgg",storage="fstree"} 0
  1. See that metrics have not actual shard IDs

Regression

No

Version

FrostFS Storage node
Version: v0.37.0-rc.1-236-g675eec91
GoVersion: go1.20.1

Your Environment

Virtual
4 nodes

## Expected Behavior ShardID in write_cache metrics should be actual. ## Current Behavior Wrong shardID in write_cache metrics ## Steps to Reproduce (for bugs) 1. Load objects to system 2. Get shards list ``` root@acidrock-node3:~# sudo frostfs-cli --endpoint 127.0.0.1:8091 -w /etc/frostfs/storage/wallet.json --config /tmp/storage.yaml control shards list |grep Shard Shard 2b2YD4bD9PRxFxyzHAhts9: Shard 36GWtTpmrysnEbVg6W9DeY: Shard 57tq8ASxdQfz7U2mbPiGSS: Shard 5ucn5La3mgb5X56CRdD2vi: Shard 7Bp81xgzjXjb9aZaye1NaY: Shard 9iEZkF2baYX3vYXhZy8RAn: Shard ALFPBFPL5DJGH3CdawtEJ6: Shard CkTWM7dZHX8VJ27zytDZ7s: Shard DKWL6gS9Rud2weL677pE7B: Shard Jm2CDQFxLEx5Crx5dLgVLQ: Shard SF3GFXQuiSFjhLby2jw3x5: Shard WBqmYHpikU885KR7bTYWmx: ``` 3. Get write_cache metrics ``` service@acidrock-node3:~$ curl -s localhost:6672 | grep frostfs_node_writecache_actual_objects_total # HELP frostfs_node_writecache_actual_objects_total Actual objects count in writecache # TYPE frostfs_node_writecache_actual_objects_total gauge frostfs_node_writecache_actual_objects_total{shard_id="8iGfU7isckfx955JymebgF",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="8iGfU7isckfx955JymebgF",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="9keJuCxVGeT6RRKhL64tPf",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="9keJuCxVGeT6RRKhL64tPf",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="AoUGTA2St7hnSgsWR2piDb",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="AoUGTA2St7hnSgsWR2piDb",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="CbRYuBY6fQQBfCz8nXa3P8",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="CbRYuBY6fQQBfCz8nXa3P8",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="FDg785WYwBoW8cVEUMz8dh",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="FDg785WYwBoW8cVEUMz8dh",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="MNdpKFc27B19QMJ5tNek2t",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="MNdpKFc27B19QMJ5tNek2t",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="NFPPgeEwfRMFwzfJLHF92u",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="NFPPgeEwfRMFwzfJLHF92u",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="RgBH9fQVGCiHba2ayrFVfh",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="RgBH9fQVGCiHba2ayrFVfh",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="S92ymKDcqHyjv1EB9UT7Pq",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="S92ymKDcqHyjv1EB9UT7Pq",storage="fstree"} 1 frostfs_node_writecache_actual_objects_total{shard_id="VFZStpQoxrrk4BmeCX3bo5",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="VFZStpQoxrrk4BmeCX3bo5",storage="fstree"} 0 frostfs_node_writecache_actual_objects_total{shard_id="WJ2bwYKp1fE3ni4SVNMUkn",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="WJ2bwYKp1fE3ni4SVNMUkn",storage="fstree"} 1 frostfs_node_writecache_actual_objects_total{shard_id="WpciPW28k4dzDBYMwehDgg",storage="db"} 0 frostfs_node_writecache_actual_objects_total{shard_id="WpciPW28k4dzDBYMwehDgg",storage="fstree"} 0 ``` 4. See that metrics have not actual shard IDs ## Regression No ## Version ``` FrostFS Storage node Version: v0.37.0-rc.1-236-g675eec91 GoVersion: go1.20.1 ``` ## Your Environment Virtual 4 nodes
anikeev-yadro added the
bug
triage
 labels 2024-01-31 15:05:20 +00:00
anikeev-yadro commented 2024-01-31 15:07:08 +00:00
Poster

Suggest to add path of the write_cache to metric labels. It will be more informative.
As example

# HELP frostfs_node_fstree_mode FSTree mode value
# TYPE frostfs_node_fstree_mode gauge
frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data0",shard_id="DKWL6gS9Rud2weL677pE7B"} 1
frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data1",shard_id="36GWtTpmrysnEbVg6W9DeY"} 1
frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data10",shard_id="WBqmYHpikU885KR7bTYWmx"} 1
Suggest to add path of the write_cache to metric labels. It will be more informative. As example ``` # HELP frostfs_node_fstree_mode FSTree mode value # TYPE frostfs_node_fstree_mode gauge frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data0",shard_id="DKWL6gS9Rud2weL677pE7B"} 1 frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data1",shard_id="36GWtTpmrysnEbVg6W9DeY"} 1 frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data10",shard_id="WBqmYHpikU885KR7bTYWmx"} 1 ```
fyrchik added the
frostfs-node
 label 2024-01-31 17:14:54 +00:00
fyrchik added this to the v0.38.0 milestone 2024-01-31 17:14:56 +00:00
fyrchik removed the
triage
 label 2024-01-31 17:15:01 +00:00
fyrchik commented 2024-02-07 06:40:57 +00:00
Owner

If easier, lets add path in a separate task, it is not a bug.

If easier, lets add path in a separate task, it is not a bug.
👍 1
anikeev-yadro commented 2024-02-07 07:25:18 +00:00
Poster

If easier, lets add path in a separate task, it is not a bug.

#966

> If easier, lets add path in a separate task, it is not a bug. https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/966
acid-ant was assigned by fyrchik 2024-02-12 06:26:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
fix/cli_control_targets
master
support/v0.38
support/v0.37
support/v0.36
support/v0.34
support/v0.30
support/v0.27
v0.39.0
v0.38.6
v0.38.5
v0.38.4
v0.38.3
v0.38.2
v0.38.1
v0.38.0
v0.38.0-rc.2
v0.38.0-rc.1
v0.37.0
v0.37.0-rc.1
v0.36.0
v0.34.0
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
v0.38.0
Assignees
Clear assignees
No Assignees
acid-ant
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#948
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?