Add path of the write_cache to metric labels #966

Closed
opened 2024-02-07 07:24:57 +00:00 by anikeev-yadro · 1 comment
Member

Not a problem

Describe the solution you'd like

Suggest to add path of the write_cache to metric labels. It will be more informative.
As example blobovnitsa and fstree metrics:

# HELP frostfs_node_fstree_mode FSTree mode value
# TYPE frostfs_node_fstree_mode gauge
frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data0",shard_id="DKWL6gS9Rud2weL677pE7B"} 1
# HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode
# TYPE frostfs_node_blobovnicza_tree_mode gauge
frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data0/blobovnicza",shard_id="K4Yyjo1LeGfH4uMueD9Psb"} 1
## Is your feature request related to a problem? Please describe. Not a problem ## Describe the solution you'd like Suggest to add path of the write_cache to metric labels. It will be more informative. As example blobovnitsa and fstree metrics: ``` # HELP frostfs_node_fstree_mode FSTree mode value # TYPE frostfs_node_fstree_mode gauge frostfs_node_fstree_mode{mode="READ_WRITE",path="/srv/frostfs/data0",shard_id="DKWL6gS9Rud2weL677pE7B"} 1 ``` ``` # HELP frostfs_node_blobovnicza_tree_mode Blobovnicza tree mode # TYPE frostfs_node_blobovnicza_tree_mode gauge frostfs_node_blobovnicza_tree_mode{mode="READ_WRITE",path="/srv/frostfs/data0/blobovnicza",shard_id="K4Yyjo1LeGfH4uMueD9Psb"} 1 ```
anikeev-yadro added the
triage
label 2024-02-07 07:24:57 +00:00
fyrchik added the
discussion
frostfs-node
observability
labels 2024-02-07 07:52:59 +00:00
fyrchik added this to the vNext milestone 2024-02-07 07:53:04 +00:00
fyrchik modified the milestone from vNext to v0.39.0 2024-02-28 19:24:11 +00:00
Owner

This should be a const label, like shard ID (i.e. set on the shard level and not being present in the writecache metrics interface)

This should be a const label, like shard ID (i.e. set on the shard level and not being present in the writecache metrics interface)
achuprov was assigned by fyrchik 2024-04-09 07:01:46 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#966
No description provided.