blobovnicza: Do not fail rebuild on objects larger than object size #1020

dstepanov-yadro · 2024-03-04T09:02:06Z

dstepanov-yadro commented

2024-03-04 09:02:06 +00:00

If blobovnicza contains objects larger than object size parameter
value, then rebuild fails with an error, because there is no such
bucket in database. This commit forces to create bucket on rebuild.

Relates #984

If blobovnicza contains objects larger than object size parameter value, then rebuild fails with an error, because there is no such bucket in database. This commit forces to create bucket on rebuild. Relates #984

dstepanov-yadro force-pushed fix/rebuild_big_objects from 448f51d396 to 362a1510c4

2024-03-04 09:07:00 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2024-03-04 10:14:40 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-03-04 10:14:40 +00:00

acid-ant approved these changes 2024-03-04 18:54:10 +00:00

fyrchik added this to the v0.39.0 milestone 2024-03-05 07:41:16 +00:00

fyrchik removed this from the v0.39.0 milestone 2024-03-05 07:41:19 +00:00

aarifullin approved these changes 2024-03-20 10:07:57 +00:00

fyrchik reviewed 2024-03-20 11:26:35 +00:00

pkg/local_object_storage/blobovnicza/put.go Outdated

					
				@ -33,2 +35,4 @@

				}

				// SetForce sets force option.

				func (p *PutPrm) SetForce(f bool) {

fyrchik commented

2024-03-20 11:26:35 +00:00

Force is such an overloaded term (I am also a sinner), what about IgnoreSizeCheck?
I don't insist, can leave as it is.

Force is such an overloaded term (I am also a sinner), what about `IgnoreSizeCheck`? I don't insist, can leave as it is.

👍 1

dstepanov-yadro commented

2024-04-08 08:16:07 +00:00

Then I leave as it is.

fyrchik marked this conversation as resolved

fyrchik approved these changes 2024-03-20 11:26:40 +00:00

dstepanov-yadro force-pushed fix/rebuild_big_objects from 362a1510c4 to e50f9dbc5e

2024-04-08 08:10:50 +00:00

Compare

fyrchik approved these changes 2024-04-08 08:25:47 +00:00

dstepanov-yadro force-pushed fix/rebuild_big_objects from e50f9dbc5e to bec518fb62

2024-04-09 07:21:26 +00:00

Compare

elebedeva approved these changes 2024-04-09 08:17:16 +00:00

fyrchik merged commit 5b8200de88 into master

2024-04-09 11:51:20 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

5 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1020